-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lit
and FileCheck
to tools and run llvmpasses by default
#28841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Have you checked that everything still works when running the llvmpasses tests with a source build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lit
and FileCheck
to toolslit
and FileCheck
to tools and run llvmpasses by default
Now includes #28330 and I fixed a couple of issues that I noted with out-of-tree builds. |
Ok fixed a problem with the source install of LLVM. In order to test this a |
Alloc opt got smarter. This makes a bunch of tests basically useless because they get optimized out entirely, but keep them to make sure it stays that way.
CI failure is network |
Installing
lit
is ugly since it comes as a Python package, but imho still better than pointing it into the source-tree.#28330 and #28838