fix description of kwargs... #28757
Merged
fix description of kwargs... #28757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
approved these changes
Aug 19, 2018
Merged
KristofferC
reviewed
Aug 19, 2018
doc/src/manual/functions.md
Outdated
| @@ -541,6 +541,10 @@ function f(x; y=0, kwargs...) | |||
| end | |||
| ``` | |||
|
|
|||
| Inside `f`, `kwargs` will be a key-value iterator over a named tuple. Named | |||
| tuples (as well as dictionaries) can be passed as keyword arguments using a | |||
There was a problem hiding this comment.
Is it worth mentioning that the keys of the dictionary should be Symbols?
There was a problem hiding this comment.
Sounds good. Updated.
KristofferC
pushed a commit
that referenced
this pull request
Aug 20, 2018
* fix description of kwargs... * clarify the key type of dicts passed as kwargs (cherry picked from commit 3a54c14)
staticfloat
pushed a commit
that referenced
this pull request
Aug 24, 2018
* fix description of kwargs... * clarify the key type of dicts passed as kwargs
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
* fix description of kwargs... * clarify the key type of dicts passed as kwargs (cherry picked from commit 3a54c14)
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
* fix description of kwargs... * clarify the key type of dicts passed as kwargs (cherry picked from commit 3a54c14)
KristofferC
added
docs
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
* fix description of kwargs... * clarify the key type of dicts passed as kwargs (cherry picked from commit 3a54c14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought
kwargsis a named tuple from this description in the manual but actually it isn't (oh why!?). So I fixed it and relocated the paragraph to a better place.