Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing GC root in interpreter.c #28742

Merged
merged 2 commits into from
Aug 18, 2018
Merged

Fix missing GC root in interpreter.c #28742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3de6f2f
Fix missing GC root in interpreter.c
Keno Aug 18, 2018
ba68ac8
Fix another missing GC root
Keno Aug 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/interpreter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ static void eval_abstracttype(jl_expr_t *ex, interpreter_state *s)
jl_datatype_t *dt = NULL;
jl_value_t *w = NULL;
jl_module_t *modu = s->module;
JL_GC_PUSH4(&para, &super, &temp, &w);
JL_GC_PUSH5(&para, &super, &temp, &w, &dt);
assert(jl_is_svec(para));
if (jl_is_globalref(name)) {
modu = jl_globalref_mod(name);
Expand Down Expand Up @@ -397,7 +397,9 @@ SECT_INTERP static jl_value_t *eval_value(jl_value_t *e, interpreter_state *s)
if (jl_is_pinode(e)) {
jl_value_t *val = eval_value(jl_fieldref_noalloc(e, 0), s);
#ifndef JL_NDEBUG
JL_GC_PUSH1(&val);
jl_typeassert(val, jl_fieldref_noalloc(e, 1));
JL_GC_POP();
#endif
return val;
}
Expand Down