Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarter order of checks in jl_types_equal #28677

Merged
merged 1 commit into from
Aug 16, 2018
Merged

smarter order of checks in jl_types_equal #28677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/subtype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,6 +1188,13 @@ JL_DLLEXPORT int jl_types_equal(jl_value_t *a, jl_value_t *b)
{
if (obviously_egal(a, b)) return 1;
if (obviously_unequal(a, b)) return 0;
if (jl_is_datatype(a) && !jl_is_concrete_type(b)) {
// if one type looks more likely to be abstract, check it on the left
// first in order to reject more quickly.
jl_value_t *temp = a;
a = b;
b = temp;
}
return jl_subtype(a, b) && jl_subtype(b, a);
}

Expand Down