Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerate documented REPL banner #28520

Merged
merged 3 commits into from
Aug 11, 2018
Merged

Autogenerate documented REPL banner #28520

merged 3 commits into from
Aug 11, 2018

Conversation

HarrisonGrodin
Copy link
Contributor

@HarrisonGrodin HarrisonGrodin commented Aug 8, 2018 •
edited by fredrikekre
Loading

fixes #28584

KristofferC
KristofferC reviewed Aug 8, 2018
View reviewed changes
stdlib/REPL/docs/src/index.md Outdated
|__/ | x86_64-linux-gnu

julia>
julia>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace I think

Copy link
Contributor Author

@HarrisonGrodin HarrisonGrodin Aug 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed.

@fredrikekre
Copy link
Member

You can instead do what we do at the top of https://github.com/JuliaLang/julia/blob/master/doc/src/manual/getting-started.md and generate it at build time.

@HarrisonGrodin
Autogenerate REPL banner
4ba39f7 
Based on the "Getting Started" manual page.
@HarrisonGrodin HarrisonGrodin changed the title Update documented REPL banner for 1.0-rc1 Autogenerate documented REPL banner Aug 8, 2018
@waldyrious
Copy link
Contributor

For future reference, this PR updates the docs to match the changes made in #28522 and #27231.

@fredrikekre fredrikekre mentioned this pull request Aug 11, 2018
Closed
@fredrikekre fredrikekre merged commit 7c9383f into JuliaLang:master Aug 11, 2018
@HarrisonGrodin HarrisonGrodin deleted the patch-3 branch August 11, 2018 11:50
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@HarrisonGrodin @KristofferC
Autogenerate documented REPL banner (#28520)
781c8d7 
* Update documented REPL banner for 1.0

(cherry picked from commit 7c9383f)
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@HarrisonGrodin @KristofferC
Autogenerate documented REPL banner (#28520)
0ad6173 
* Update documented REPL banner for 1.0

(cherry picked from commit 7c9383f)
@KristofferC KristofferC mentioned this pull request Aug 19, 2018
Merged
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@HarrisonGrodin @KristofferC
Autogenerate documented REPL banner (#28520)
396e2b1 
* Update documented REPL banner for 1.0

(cherry picked from commit 7c9383f)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@HarrisonGrodin @KristofferC
Autogenerate documented REPL banner (#28520)
32cf6d8 
* Update documented REPL banner for 1.0

(cherry picked from commit 7c9383f)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@HarrisonGrodin @KristofferC
Autogenerate documented REPL banner (#28520)
4e1178c 
* Update documented REPL banner for 1.0

(cherry picked from commit 7c9383f)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@HarrisonGrodin @KristofferC
Autogenerate documented REPL banner (#28520)
bd04cab 
* Update documented REPL banner for 1.0

(cherry picked from commit 7c9383f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REPL Documentation outdated for 0.7/1.0
4 participants
@HarrisonGrodin @fredrikekre @waldyrious @KristofferC