Hooked GDB to JITEventListener, cleaned jitlayers GDB interface #28407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Aug 2, 2018
src/jitlayers.cpp
Outdated
| @@ -70,6 +71,9 @@ using namespace llvm; | |||
| #include "julia_assert.h" | |||
|
|
|||
| RTDyldMemoryManager* createRTDyldMemoryManager(void); | |||
| using namespace llvm; | |||
There was a problem hiding this comment.
Why do we need these new namespaces?
src/jitlayers.cpp
Outdated
| @@ -54,7 +54,8 @@ namespace llvm { | |||
| #include <llvm/IR/DataLayout.h> | |||
| #include <llvm/Support/DynamicLibrary.h> | |||
|
|
|||
|
|
|||
| #include <llvm/ExecutionEngine/ExecutionEngine.h> | |||
| #include <llvm/ExecutionEngine/JITEventListener.h> | |||
fisiognomico
force-pushed
the
df/GDBlistener
branch
from
32da9af to
49bfbfa
Compare
|
Sorry, I forgot them there. At CI an error very similar to #28379 appeared, I hope that after rebase they will pass. |
fisiognomico
force-pushed
the
df/GDBlistener
branch
2 times, most recently
from
6d55c8e to
aa8a558
Compare
|
Bump! CI now passes |
vchuravy
reviewed
Aug 11, 2018
src/jitlayers.cpp
Outdated
| @@ -402,10 +336,9 @@ void JuliaOJIT::DebugObjectRegistrar::registerObject(RTDyldObjHandleT H, const O | |||
| std::move(NewBuffer)); | |||
| } | |||
| else { | |||
| NotifyGDB(SavedObject); | |||
| JIT.NotifyFinalizer(*(SavedObject.getBinary()), *LO); | |||
src/jitlayers.cpp
Outdated
| @@ -70,6 +69,7 @@ using namespace llvm; | |||
| #include "julia_assert.h" | |||
|
|
|||
| RTDyldMemoryManager* createRTDyldMemoryManager(void); | |||
| using namespace llvm::object; | |||
There was a problem hiding this comment.
Without it I get a compilation error : Owning Binary not declared in this scope.
There was a problem hiding this comment.
Instead of using the namespace can you prefix the names? If it is a lot more than a handful place the namespace is ok, but I suspect it is only in one or two places.
There was a problem hiding this comment.
Oh, yeah effectively it can be more convenient :D
fisiognomico
force-pushed
the
df/GDBlistener
branch
2 times, most recently
from
8d229b9 to
ff2b0ce
Compare
|
Should this be backported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #27466 we can hook GDB Listener to JITEventListener.
cc @vtjnash @vchuravy