Revert "The return of the "Generate precompilation as part of build process #28346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #28319 passes tests and provide a good REPL experience with building locally it has one problem that I failed to realize before merging.
The generator script implicitly assumes that
stdin
is a TTY in order for the record of the startup process to be the same as for a user. This works well if you build locally but the for the buildbots this is not the case (stdin is redirected to a file or something). This means that the recorded precompilation statements are non-accurate and this harms startup time and REPL startup time compared to the hardcoded precompilation statements.It is obvious that something is off by looking at the number of precompilation statements that gets generated locally (~730) vs on the buildbots (~650).
So I think it is best to revert this and get a proper version going that creates its own TTY and have no assumptions on the building environment.
I apologize for the frequent merging / revert cycle lately :(