Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable abstract interpreter to constant prop even if method source is generated #28282

Closed
wants to merge 1 commit into from

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Jul 25, 2018

I made this change entirely because @vtjnash dreamed that he had already made me make this change, and was surprised to find that this was not the case in his wakeful reality

@jrevels jrevels changed the title enable abstract interpreter to inline even if method source is generated enable abstract interpreter to constant prop even if method source is generated Jul 25, 2018
@Keno
Copy link
Member

Keno commented Jul 25, 2018

I made this change entirely because @vtjnash dreamed that he had already made me make this change, and was surprised to find that this was not the case in his wakeful reality

More common than you think. I dreamed last night that @yuyichao had left a review comment on my #28251 PR asking for an LLVM-level test case of the new feature, but that comment is nowhere to be found.

@vtjnash
Copy link
Member

vtjnash commented Jul 26, 2018

Maybe it's a good thing it hadn't translated into reality. I'm really not sure that this is a good idea.

@JeffBezanson JeffBezanson added the compiler:inference Type inference label Jul 26, 2018
@jrevels
Copy link
Member Author

jrevels commented Jul 26, 2018

@nanosoldier runbenchmarks(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@vtjnash vtjnash closed this Dec 18, 2018
@vtjnash
Copy link
Member

vtjnash commented Dec 18, 2018

we might want to do this if the Method spoofing bit is set in the CodeInfo, but we'll revisit that when we run into it

@ararslan ararslan deleted the jr/doasyouaretold branch December 18, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants