Test: unexport guardsrand #27942
Merged
Test: unexport guardsrand #27942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly superseded by the new behavior of at-testset, which reinitializes the state of the GLOBAL_RNG.
StefanKarpinski
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly superseded by the new behavior of
@testset, which reinitializes the state of the GLOBAL_RNG.As
guardsrandwas introduced in 0.7, I don't think it needs a deprecation. It could also be entirely removed, as the few uses in the repo could easily be replaced by@testsetor by using an explicit RNG.I'm just not clear if code which was moved out of the repo contains call to this function.(EDIT: I found onlyIterativeEigensolversremoved from the repo, which doesn't use anymoreguardsrand).