-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete for NamedTuples #27725
Closed
Closed
delete for NamedTuples #27725
Changes from 32 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
e747501
add `dropnames`
JeffreySarnoff fdd3a98
add dropnames tests
JeffreySarnoff a239411
change `dropnames` to `delete`
JeffreySarnoff 36af455
change `dropnames` to `delete`
JeffreySarnoff e33cea2
export `delete` (namedtuples)
JeffreySarnoff fc46f7a
shorten docstring for `delete`
JeffreySarnoff 0338959
add `delete(::NamedTuple, ::Symbol)`
JeffreySarnoff 0bc6e80
add tests for `delete(::NamedTuple, ::Symbol)`
JeffreySarnoff 354d543
another test for `delete(::NamedTuple, ::Symbol)`
JeffreySarnoff cf160bb
reword delete docstring for clarity
JeffreySarnoff ec186c5
rework delete docstring for clarity
JeffreySarnoff 524bc8b
test typeof(delete(..)) is fully specified
JeffreySarnoff 65aac32
add, comment out @inferred for delete
JeffreySarnoff db79715
uncomment @inferrable tests
JeffreySarnoff 14dbfd2
use recommended @inferred test
JeffreySarnoff 292d88e
remove test `@inferred delete`
JeffreySarnoff 619fe4c
Base.delete --> delete in tests
JeffreySarnoff 3606bec
comment out delete tests (see what circleci does)
JeffreySarnoff d43cf81
temp comment out delete() to see what circleci does
JeffreySarnoff 99a3d20
rename delete(nt, tuple) to deleteindicies, change docstr
JeffreySarnoff be15cc1
export deleteindicies
JeffreySarnoff a4abb90
test deleteindicies
JeffreySarnoff 2f37e71
Update namedtuple.jl
JeffreySarnoff 308deb6
Update namedtuple.jl
JeffreySarnoff e1ae2de
delete(nt, :sym), delete(nt, :sym1, :sym2)
JeffreySarnoff 86a4b12
replace deleteindicies with delete
JeffreySarnoff 5226c03
remove space
JeffreySarnoff ea3aeae
remove deleteindicies
JeffreySarnoff 4704588
test delete with no fieldnames
JeffreySarnoff 2202264
corrected signature, docstring
JeffreySarnoff b10fced
fix typo
JeffreySarnoff 6f6f25b
fixup delete test
JeffreySarnoff 993cc2b
Update namedtuple.jl
JeffreySarnoff 54198b3
Fix signature in docstring
nalimilan 14d0b46
delete limited to one symbol
JeffreySarnoff 5559d8e
delete limited to one symbol
JeffreySarnoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -482,6 +482,7 @@ export | |
firstindex, | ||
collect, | ||
count, | ||
delete, | ||
delete!, | ||
deleteat!, | ||
eltype, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
symbol(s)
doesn't make sense here (see my previous comment).