Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FileWatching tolerances #27707

Merged
merged 2 commits into from
Jun 22, 2018
Merged

Bump FileWatching tolerances #27707

merged 2 commits into from
Jun 22, 2018

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat commented Jun 21, 2018

It's very difficult to know if these are actually sufficient, but I guess we'll see if things improve. Two fixes here; the first is for #26725; it puts a sleep within a for loop so that there's some space in between rm() calls. We'll see if this actually has any effect other than adding a few tenths of a second to our test suite. The second is for #27287 to generally bump all time thresholds from 0.3 seconds up to 0.5, as our windows buildbot fs performance while under load is so bad that we need it that high.

This is to account for the abysmal fs performance we get on our windows
buildbots.
@mbauman
Copy link
Member

mbauman commented Jun 22, 2018

Travis Win32 failed with a GC segfault in bidiag, 64bit CircleCI was OOM killed during compilation.

@mbauman mbauman merged commit dd49081 into master Jun 22, 2018
@mbauman mbauman deleted the sf/filewatching branch June 22, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants