disallow unrecognized escapes in unescape_string (part of #21284) #27238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an error when encountering unknown/unrecognized escape sequences in
unescape_string
(currently unrecognized single letter sequences like\m
,\j
, etc. are silently replaced by their corresponding character (m, j, ...) byunescape_string
).This seems to have been the intention behind test changes in #22800, and it will make fixing things like #27125 easier.