-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new optimizer by default #27087
Conversation
Can we run binary builder on this PR (helps with doing PkgEval) |
Getting this on Circle:
Once this branch builds and passes and all that, we can just trigger a buildbot build using the branch SHA, then running PackageEvaluator using the resulting binary is quite straightforward. (Essentially the same as is outlined in DISTRIBUTING.md.) |
Yeah, I saw, looks like we need to |
How is the compile time using the new vs. the old optimizer, e.g. building the sysimg? |
Worse, but we intend to address that in the 1.0 time frame. |
How much worse? |
About 40% regression on pure sysimg build time (stdlib is essentially unchanged) it seems. That includes the time it takes to compile the optimizer itwelf. A bit less when disabling the IR verifier which we should do. Don't think that's entirely due to compile time regression testing though. We may have to take a look at the inlining thresholds post new optimizer, since the IR looks quite a bit different now. On the other hand, last I checked it was about on par if we also merge kf/iterate (makes the old optimizer quite a bit slower, essentially no effect on the new one). |
🎉 |
Got error on master branch build, after this PR merged. |
seems it's FreeBSD only issue. |
Reported in #27109 |
No description provided.