Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rebase #24478 #26990

Merged
merged 3 commits into from
May 7, 2018
Merged

WIP: Rebase #24478 #26990

merged 3 commits into from
May 7, 2018

Conversation

Keno
Copy link
Member

@Keno Keno commented May 5, 2018

This is a WIP rebase of #24478. The changes in that PR would fix a bunch of the regressions immediately in #26795, so I want to see what it would take to get that merged before I start writing fancier julia-level optimization passes.

@Keno
Copy link
Member Author

Keno commented May 5, 2018

@nanosoldier runbenchmarks(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

yuyichao and others added 3 commits May 6, 2018 17:43
* Remove some tag handling code that's not needed anymore
* Put all the states in a struct

    There are already too many of them to pass around
    and there will likely be even more in the future
This allow us to handle certain object allocations with object reference fields.
DSE is particularly useful on LLVM 5.0+ where we can take advantage of llvm store to load
forwarding to delete objects that's only used as local buffer.

This is also a prototype for the next gen optimization in type inference and to guide
the new IR format necessary for it.

Fix #16190
@Keno Keno force-pushed the kf/yyc/codegen/alloc2 branch from 81d44f0 to 3113017 Compare May 6, 2018 21:43
@Keno
Copy link
Member Author

Keno commented May 6, 2018

I found and fixed the use after free that was causing crashes on LLVM6. I believe this should be working now, so I'm gonna plan to merge if CI passes.

@vchuravy
Copy link
Member

vchuravy commented May 6, 2018

@nanosoldier runbenchmarks(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@Keno Keno merged commit 8eb3dcc into master May 7, 2018
@vchuravy vchuravy deleted the kf/yyc/codegen/alloc2 branch May 7, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants