Support context module in replcompletions #26930

jamii · 2018-04-29T15:22:50Z

RE: https://discourse.julialang.org/t/networked-repl/2085/15?u=jamii

@pfitzseb as promised :)

This just adds the context module.

For structured completions, I could:

Change the return type of completions and fix the usage in REPL. Then IJulia and co have to change their usage code.
Make a new structured_completions function that does all the work and completions calls that and converts the results to strings. Avoids breaking downstream stuff, but leaves a gross api wart.

Which is preferable?

jamii · 2018-04-30T14:57:25Z

AppVeyor: Build execution time has reached the maximum allowed time for your plan (120 minutes).

Travis: Error in testset SparseArrays/sparsevector:

Doesn't seem to be anything to do with this PR.

KristofferC · 2018-04-30T15:00:31Z

The 1/10000 hits again? #26909

pfitzseb · 2018-04-30T15:01:05Z

Looks good to me! I think I'd vastly prefer the first option (changing the return type of completions), since tooling will need to be updated for 0.7 anyways.
What precisely do you want to change the return type to?

Also, are you looking into extending this to enable changing the module the REPL evals into?

jamii · 2018-04-30T17:40:47Z

What precisely do you want to change the return type to?

A different struct for each completion type, so that clients can render/complete them appropriately. Eg in my emacs autocomplete I need to parse method completions like "string(x::BigInt) in Base.GMP at gmp.jl:568" to know not to insert that literal text into the file. It would be nicer to get MethodCompletion(::Method) and decide what to do with it myself.

Also, are you looking into extending this to enable changing the module the REPL evals into?

Probably not. I don't use the repl much myself and I haven't had much luck integrating my emacs tools with it directly. I would want to send text to an active repl from Julia and have it behave as if it were pasted in, but this seems to be nontrivial. I noticed Juno doesn't show evaled text in the repl either - is this by design or because it's hard?

pfitzseb · 2018-04-30T18:21:23Z

A different struct for each completion type, so that clients can render/complete them appropriately.

Sounds great.

Probably not. I don't use the repl much myself and I haven't had much luck integrating my emacs tools with it directly.

Alright, fair enough. I'll look into it then :)

I would want to send text to an active repl from Julia and have it behave as if it were pasted in, but this seems to be nontrivial. I noticed Juno doesn't show evaled text in the repl either - is this by design or because it's hard?

It's not trivial, but definitely doable. A super hackish solution would be something like this, but I'm sure one could reuse much more of the REPL implementation. You'd also need to restore what was previously entered on the prompt, but IIRC 0.7 has support for that.

Juno doesn't display evaled text in the REPL by design.

jamii · 2018-04-30T21:57:21Z

I'm sure one could reuse much more of the REPL implementation

I mostly wanted to handle prompt pasting without implementing it myself, so I would need to push it through the repl parser at least. Probably not the most important thing to focus on right now. I'll look at it again in the future.

jamii · 2018-05-04T14:40:33Z

This is more or less there now, except there's a noticeable compilation delay now the first time I complete something in the repl. I probably need to add some precompilation signatures?

jamii · 2018-05-13T11:39:20Z

Looks like the AppVeyor build timed out.

...except there's a noticeable compilation delay now the first time I complete something in the repl

This disappears when REPL is precompiled via make (I had disabled precompilation for REPL during development).

I think it's good to go @pfitzseb

KristofferC · 2018-06-18T09:05:46Z

Restarting CI since it was a while ago.

jamii · 2018-06-18T12:32:29Z

Looks like the first failure is a build timeout, but the second one is interesting:

Error in testset REPL:
Error During Test at /usr/home/julia/julia-fbsd-buildbot/worker/11rel-amd64/build/test/testdefs.jl:19
  Got exception LoadError("/usr/home/julia/julia-fbsd-buildbot/worker/11rel-amd64/build/usr/share/julia/stdlib/v0.7/REPL/test/runtests.jl", 7, LoadError("/usr/home/julia/julia-fbsd-buildbot/worker/11rel-amd64/build/usr/share/julia/stdlib/v0.7/REPL/test/replcompletions.jl", 600, ErrorException("PCRE.exec error: UTF-8 error: isolated byte with 0x80 bit set"))) outside of a @test
  LoadError: LoadError: PCRE.exec error: UTF-8 error: isolated byte with 0x80 bit set
  Stacktrace:
   [1] error at ./error.jl:33 [inlined]
   [2] exec at ./pcre.jl:137 [inlined]
   [3] findnext(::Regex, ::String, ::Int64) at ./regex.jl:222
   [4] #replace#334(::Int64, ::Function, ::String, ::Pair{Regex,String}) at ./strings/util.jl:450
   [5] replace at ./strings/util.jl:444 [inlined]
   [6] #complete_path#11(::Bool, ::Function, ::String, ::Int64) at /usr/home/julia/julia-fbsd-buildbot/worker/11rel-amd64/build/usr/share/julia/stdlib/v0.7/REPL/src/REPLCompletions.jl:263
   [7] #complete_path at ./int.jl:0 [inlined]
   [8] shell_completions(::String, ::Int64) at /usr/home/julia/julia-fbsd-buildbot/worker/11rel-amd64/build/usr/share/julia/stdlib/v0.7/REPL/src/REPLCompletions.jl:734
   [9] test_scomplete(::String) at /usr/home/julia/julia-fbsd-buildbot/worker/11rel-amd64/build/usr/share/julia/stdlib/v0.7/REPL/test/replcompletions.jl:112

While trying to autocomplete /tmp/ in the shell.

jamii · 2018-06-18T13:08:17Z

I'm not able to replicate this locally. Presumably it depends on what files exist in /tmp. It doesn't seem to be related to this PR though - the error is in a regex that I didn't change.

KristofferC · 2018-06-18T21:46:07Z

#27642

jamii · 2018-06-21T17:17:36Z

Looks like #27642 should be fixed. Let's try CI again.

jamii · 2018-07-05T15:39:20Z

One timeout, one OOM. Unrelated.

KristofferC · 2018-07-05T15:47:36Z

Sorry for this taking time. Since last CI was 14 days ago, we should rerun it.

jamii · 2018-07-05T15:48:26Z

No worries. I assume 1.0 is looming :)

vtjnash · 2018-07-05T15:57:39Z

Seems like that doesn't trigger CircleCI

KristofferC · 2018-07-05T16:21:27Z

Restarted manually.

jamii · 2018-07-09T13:38:27Z

We have:

/tmp/julia/bin/julia-debug: No such file or directory
/tmp/julia/bin/julia-debug: No such file or directory
Error in testset FileWatching:
Error in testset download:

The repl tests seem to pass on the platforms where the build gets that far.

Support context module in replcompletions

c7df68c

Add more useful info to completions

b74fd51

kshyatt added the REPL Julia's REPL (Read Eval Print Loop) label May 27, 2018

jamii mentioned this pull request Jun 14, 2018

Base.isdeprecated causes deprecation warnings to be printed #27571

Open

jamii added 2 commits June 14, 2018 12:56

Merge branch 'master' into completions

5153e6a

Make a Completion subtype for packages

7676287

KristofferC closed this Jun 18, 2018

KristofferC reopened this Jun 18, 2018

jamii closed this Jun 21, 2018

jamii reopened this Jun 21, 2018

KristofferC closed this Jul 5, 2018

KristofferC reopened this Jul 5, 2018

KristofferC merged commit 67c19eb into JuliaLang:master Jul 9, 2018

stevengj mentioned this pull request Jul 12, 2018

Tab completion triggers kernel exception JuliaLang/IJulia.jl#679

Closed

KristofferC mentioned this pull request Jul 12, 2018

set the context_module for the REPLCompletions JuliaLang/IJulia.jl#680

Merged

JeffBezanson mentioned this pull request Jul 24, 2018

REPL completion error: UndefVarError #27184

Closed

KristofferC mentioned this pull request Aug 16, 2018

fix REPL completions not always being unique #28694

Merged

vtjnash mentioned this pull request Jun 29, 2020

Fix REPL test result uniqueness #32446

Closed

timholy mentioned this pull request Aug 19, 2020

Improve inference broadly throughout REPL #37081

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support context module in replcompletions #26930

Support context module in replcompletions #26930

jamii commented Apr 29, 2018 •

edited

Loading

jamii commented Apr 30, 2018 •

edited

Loading

KristofferC commented Apr 30, 2018

pfitzseb commented Apr 30, 2018 •

edited

Loading

jamii commented Apr 30, 2018

pfitzseb commented Apr 30, 2018

jamii commented Apr 30, 2018 •

edited

Loading

jamii commented May 4, 2018

jamii commented May 13, 2018 •

edited

Loading

KristofferC commented Jun 18, 2018

jamii commented Jun 18, 2018

jamii commented Jun 18, 2018

KristofferC commented Jun 18, 2018

jamii commented Jun 21, 2018

jamii commented Jul 5, 2018

KristofferC commented Jul 5, 2018

jamii commented Jul 5, 2018

vtjnash commented Jul 5, 2018

KristofferC commented Jul 5, 2018

jamii commented Jul 9, 2018

Support context module in replcompletions #26930

Support context module in replcompletions #26930

Conversation

jamii commented Apr 29, 2018 • edited Loading

jamii commented Apr 30, 2018 • edited Loading

KristofferC commented Apr 30, 2018

pfitzseb commented Apr 30, 2018 • edited Loading

jamii commented Apr 30, 2018

pfitzseb commented Apr 30, 2018

jamii commented Apr 30, 2018 • edited Loading

jamii commented May 4, 2018

jamii commented May 13, 2018 • edited Loading

KristofferC commented Jun 18, 2018

jamii commented Jun 18, 2018

jamii commented Jun 18, 2018

KristofferC commented Jun 18, 2018

jamii commented Jun 21, 2018

jamii commented Jul 5, 2018

KristofferC commented Jul 5, 2018

jamii commented Jul 5, 2018

vtjnash commented Jul 5, 2018

KristofferC commented Jul 5, 2018

jamii commented Jul 9, 2018

jamii commented Apr 29, 2018 •

edited

Loading

jamii commented Apr 30, 2018 •

edited

Loading

pfitzseb commented Apr 30, 2018 •

edited

Loading

jamii commented Apr 30, 2018 •

edited

Loading

jamii commented May 13, 2018 •

edited

Loading