-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build from source on alpine linux #26358
Conversation
Nice. do you have docker images somewhere based on alpine working? |
If there's an appropriate Docker image available we should be able to add Alpine to our CI testing on CircleCI, which would arguably be more valuable than having redundant glibc Linux builds. |
Something like https://github.com/tkelman/julia-alpine/blob/master/Dockerfile seems to be working so far. Can collapse that down, do a make install and remove build-only deps once it's done if you want a small image for deployment purposes. |
Good to merge? |
Cool. Is there a released version of llvm/openblas including these changes, that we're likely to upgrade to? |
See the makefile comments - llvm 6.0.0 will include llvm-mirror/llvm@ae8900a, llvm 5.0.0 should already include llvm-mirror/llvm@32028c8, openblas 0.2.21 was supposed to be a hotfix that already included OpenMathLib/OpenBLAS#1257 (and worth noting that upstream tests against alpine on their dev branch CI now) but ref OpenMathLib/OpenBLAS#1258, xianyi is kinda MIA and no one knows what the exact release plan is there.
|
Yes the OpenBLAS release schedule is unclear. I believe we need another matvec perf fix that @simonbyrne reported too - but digressing here. Do we need to run Package Evaluator on this, since these are LLVM patches that are late in the release cycle? |
The large patch should be an llvm-internal enum renaming rather than externally visible, but maybe clang or llvm.jl are worth testing to be sure this doesn't cause any problems there. It's also entirely possible that I missed something or made a mistake when rebasing those, so might also be good to verify it's not noticeable on nanosoldier if that's working properly right now |
cc @maleadt for LLVM.jl @nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Works fine with (what's currently covered by) LLVM.jl. |
Seems like there is quite a bit of regression on some of the perf tests. Should we wait to see how the llvm 6 stuff pans out and then do what's necessary? I suspect we could do the openblas stuff right away. |
I am quite sure none of those "regressions" are from this PR. They are very spread and most of the groups with regressions also have improvements, just showing that they are noisy. @nanosoldier |
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Bump. Anything else needed here? |
Should we wait to see the situation on llvm 6 before deciding here? |
Why? LLVM 6 almost certainly will break more than this would. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rerunning CI because it was 9 days ago last time. |
Needs a rebase now but should be good to go after that. |
Patch:
|
carrying patches from: