Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use empirically found threshold to speed up issubset by creating Set … #26198

Merged
merged 2 commits into from
Mar 7, 2018
Merged

use empirically found threshold to speed up issubset by creating Set … #26198

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6764732
actually resolving the merge conflict correctly
Feb 25, 2018
2ea5fa6
update Set to AbstractSet to cover all Sets, per Jeff's suggestion
Feb 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions base/abstractset.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,16 @@ false
```
"""
function issubset(l, r)

rlen = length(r)
#This threshold was empirically determined by repeatedly
#sampling using these two methods.
lenthresh = 70

if rlen > lenthresh && !isa(r, Set)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It occurred to me that this should probably use isa(r, AbstractSet) (there are other kinds of sets, all of which should probably have efficient in methods).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. I just learned that IntSet is implemented as a bit string.

return issubset(l, Set(r))
end

for elt in l
if !in(elt, r)
return false
Expand Down