Drop support for non-indexable iterators in find* functions #26095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always call pairs(), which will throw an error for iterables which do not define it. Removing the internal _pairs() function allows supporting custom types which implement pairs(). Also fix/improve a few docstrings.
mbauman
approved these changes
Feb 17, 2018
base/array.jl
Outdated
|
|
||
| Find the next linear index >= `i` of a `true` element of `A`, or `nothing` if not found. | ||
| Find the next index after `i` of a `true` element of `A`, or `nothing` if not found. |
vtjnash
referenced
this pull request
Feb 20, 2018
require: factor out method taking a PkgId argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always call
pairs, which will throw an error for iterables which do not define it. Removing the internal_pairsfunction allows supporting custom types which implementpairs. Also fix/improve a few docstrings.No deprecation is needed since these functions relied on
getindexbeing defined on 0.6.Fixes #25999.