WIP: turn on specialization spoofing mechanism in the compiler #25639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrevels
commented
Jan 19, 2018
| edgecycle = true | ||
| break | ||
| end | ||
| if infstate.linfo.specTypes == sig |
There was a problem hiding this comment.
Should checks against signatures be replaced in the same manner as checks against methods?
jrevels
commented
Jan 19, 2018
| break | ||
| end | ||
| working_method = method_for_specialization_heuristics(infstate.src, infstate.linfo.def) | ||
| if checked_method === working_method |
There was a problem hiding this comment.
Should all method checks (that are part of specialization heuristics) be replaced like this? In general, when should the "spoof" method be used vs. the "real" method?
jrevels
changed the title
|
@jrevels Maybe pull the rename of the CodeInfo field out of this patch and merge, so it doesn't conflict? |
|
Closing because @vtjnash is going to recreate the work here in a different (hopefully more correct) PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #24852. Intends to close #24676.
The intention of this PR is to rewrite relevant parts of the compiler to respect the
signature_for_specialization_heuristicsCodeInfofield. I've started off with some very naive changes toabstract_call_methodthat are probably incorrect...