optimize and fix map/broadcast over Adjoint/Transpose vectors #25219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fix inference.
Sacha0
added
bugfix
|
I didn't consciously intend to hit merge here (just a reflex after checking that the CI errors were unrelated...), sorry about that. But hopefully there are no bad consequences. |
|
master build failed after this merged: https://freebsdci.julialang.org/#/builders/1/builds/5712 |
|
I just pushed a revert, 5fcd0d9. Sorry about that. |
|
Thanks nonetheless @timholy! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the optimization @timholy suggested in #25083 (comment) (hence closes JuliaLang/LinearAlgebra.jl#492) and fixes the inference issue @martinholters caught in #25083 (comment). Thanks and best!