-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update context-independent and remove context-dependent lowering of ' #25148
Conversation
Rebased and fixed the few test failures CI revealed. Assuming CI approves and absent objections or requests for time, I plan to merge these changes this evening PT or later and dive into the last stretch of JuliaLang/LinearAlgebra.jl#57. Best! |
base/exports.jl
Outdated
@@ -248,6 +248,7 @@ export | |||
At_mul_Bt!, | |||
At_rdiv_B, | |||
At_rdiv_Bt, | |||
postfixapostrophize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really need to be export
ed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems so? Otherwise one must import it broadly?
Why not lower |
Path of least resistance and uncertainty mostly :). |
Can also lower to |
Yes, @fredrikekre and I just came to the same conclusion on slack. That's much better. Will fix and push. Thanks! :) |
…nt(A) and clean up fallout.
|
Are we going to have to change the syntax for all of these or are these just temporary? |
Sorry, for all of what? |
|
The |
Thanks all! |
This introduced a new warning during the build:
|
@@ -2396,7 +2367,7 @@ | |||
,.(apply append rows))) | |||
`(call (top typed_vcat) ,t ,@a))))) | |||
|
|||
'|'| (lambda (e) (expand-forms `(call adjoint ,(cadr e)))) | |||
'|'| (lambda (e) (expand-forms `(call (core postfixapostrophize) ,(cadr e)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use top
not core
, and put separate definitions inside each topmodule (Inference and Base) instead of in boot.jl. That'll fix the method overwrite issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is the next step towards JuliaLang/LinearAlgebra.jl#57 after #24969, #25083, and #25125, completing items 13-17 in #24969's OP's task list. Specifically, this pull request:
'
s in base, test, and stdlib as appropriate.X'
topostfixapostrophize(X)
, and provides fallback= Adjoint(X)
.'
in multiplication, left-division, and right-division expressions.Notes:
This pull request is based on remove special lowering for and deprecate .' #25125, from which the first five commits come. Only the last five commits belong to this pull request. I will rebase those commits out once remove special lowering for and deprecate .' #25125 merges.Rebased out.Thanks and best!