Make inbounds macros expression-like

[StefanKarpinski]

In which I steal @mbauman's PR: #15558. Sorry Matt, your branch was not setup to allow me to force push it, so I just made my own to get this rebased.

[vchuravy]

@nanosoldier runbenchmarks(ALL, vs=":master")

[nanosoldier]

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

[StefanKarpinski]

Circle CI is a timeout so it seems unrelated. Any care to interpret whether the slow downs are real or not here? @vtjnash?

[KristofferC]

@nanosoldier runbenchmarks(ALL, vs=":master")

[nanosoldier]

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @ararslan

[ararslan]

Things moving to stdlib broke Nanosoldier, I'm working on fixing it now

[ararslan]

@nanosoldier runbenchmarks(ALL, vs=":master")

[ararslan]

I got a 400 from Nanosoldier so I restarted the server. @nanosoldier runbenchmarks(ALL, vs=":master")

[nanosoldier]

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @ararslan

[ararslan]

Sorry, one more change is needed, working on that now.

[ararslan]

@nanosoldier runbenchmarks(ALL, vs=":master")

[nanosoldier]

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @ararslan

[ararslan]

Okay, I think I know what happened. Should be fixed now... I hope. Sorry for guinea pigging you, Stefan. @nanosoldier runbenchmarks(ALL, vs=":master")

[nanosoldier]

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @ararslan

[ararslan]

@nanosoldier runbenchmarks(ALL, vs=":master")

[ararslan]

Had to restart the server. @nanosoldier runbenchmarks(ALL, vs=":master")

[nanosoldier]

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

[vchuravy]

LGTM.

[ararslan]

So much has changed in the 7 days since this was opened that we should rerun CI before merging just in case.

[StefanKarpinski]

Oh wow, legitimately no performance regressions. Nice.

[ararslan]

Plus both Circle failures are unrelated, so I'd say this is good to go!