Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate isnumber() in favor of isnumeric() #25008

Closed
wants to merge 1 commit into from
Closed

Conversation

nalimilan
Copy link
Member

Consistent with Python and Rust (but not Go), and less easy to confuse with isdigit(). Improve documentation to make confusion less easy.

Also fix a few uses where isdigit() is more appropriate than isnumber().

(This function would better not exist at all... 😄 )

Consistent with Python and Rust (but not Go), and less easy to confuse
with isdigit(). Improve documentation to make confusion less easy.

Also fix a few uses where isdigit() is more appropriate than isnumber().
@stevengj
Copy link
Member

stevengj commented Dec 9, 2017

I thought the consensus in #14347 was to move these functions into a stdlib package? Seems better to do any renaming at that point. Otherwise, you force people to update for deprecations twice in the 0.7 cycle.

Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's clearly a better name.

@StefanKarpinski
Copy link
Member

Yes, I was planning on doing the stdlib thing next.

@nalimilan
Copy link
Member Author

Closing in favor of #25021.

@nalimilan nalimilan closed this Dec 11, 2017
@nalimilan nalimilan deleted the nl/isnumeric branch December 11, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings "Strings!"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants