Fixes and improvements to Pkg resolver #24904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computes the dependency graph subset induced by the requirements after filter_versions has propagated the implicit requirements, rather than before, which ensures that only the parts reachable from some requirement are kept. In practice, it removes many more useless parts of the graph. (Plus other tiny improvements.)
Set the packages as fixed when checking instead of just requiring them; propagate the resolution info; improve the dependency computation efficiency; some refactoring.
Fixes the rare condition where two packages were being decimated at once in mutually inconsistent versions.
This was referenced Dec 4, 2017
|
Barring comments/objections, I'll merge later today. |
ararslan
pushed a commit
that referenced
this pull request
Apr 26, 2018
Computes the dependency graph subset induced by the requirements after filter_versions has propagated the implicit requirements, rather than before, which ensures that only the parts reachable from some requirement are kept. In practice, it removes many more useless parts of the graph. (Plus other tiny improvements.) Ref #24904 (cherry picked from commit 9b00059)
ararslan
pushed a commit
that referenced
this pull request
Apr 26, 2018
Computes the dependency graph subset induced by the requirements after filter_versions has propagated the implicit requirements, rather than before, which ensures that only the parts reachable from some requirement are kept. In practice, it removes many more useless parts of the graph. (Plus other tiny improvements.) Ref #24904 (cherry picked from commit 9b00059)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third commit fixes the assertion error which popped up in METADATA: JuliaLang/METADATA.jl#12306
The first two are general improvements; the graph gets simplified much more, and the sanity check is also made more robust. It's also faster, as checking METADATA went from 60s to 45s on my laptop.
All commits together should generally help considerably with the issues which have popped up in METADATA recently. They should also be quite straightforward to backport.
I have other improvements in mind, but I will do them in Pkg3 (once I have ported this there, and started harmonizing the codes, cc @StefanKarpinski, @KristofferC)