Cache the source text for Base and update guidelines for using Revise #24120
Conversation
On Windows just a difference in backslash/forwardslash can cause a matching failure, but we shouldn't care about such differences.
|
Hmm, while this works "on top of" an existing installation, in a fresh installation it fails because it seems I'm relying on stuff that hasn't finished installing/building. Specifically, the problem is the Makefile change that executes |
Makefile
Outdated
| @@ -226,7 +226,7 @@ $$(build_private_libdir)/sys$1.o: $$(build_private_libdir)/inference.ji $$(JULIA | |||
| mv [email protected] $$@; \ | |||
| else \ | |||
| echo '*** This error is usually fixed by running `make clean`. If the error persists$$(COMMA) try `make cleanall`. ***' && false; \ | |||
| fi ) | |||
| fi && $$(call spawn,$3) $$(JULIAHOME)/etc/write_base_cache.jl) | |||
There was a problem hiding this comment.
Separate this out into it's own build step.
julia-base-cache: julia-sysimg-% | $(DIRS) $(build_datarootdir)/julia/base
(call exec,$(JULIA_EXECUTABLE) $$JULIAHOME)/etc/write_base_cache.jl $(build_datarootdir)/julia/base/base.cache)
You might want to actually let make decide the location of the cache file and pass that to the script instead of letting the script discover if we are doing an out-of-source build, then you can add it to the list of dependencies for in L114 for julia-release julia-debug.
At least that's how I would start.
There was a problem hiding this comment.
You saved me a bunch of time. Thanks so much.
There was a problem hiding this comment.
Though do you really think it should go in usr/share/julia/base? For me that's a symlink, so it actually ends up base/, which is why I ended up adding a .gitignore. What about just putting it in usr/share/julia directly?
There was a problem hiding this comment.
That should be OK as well. If you want you can test out-of-tree builds and make install.
I am myself not a 100% sure where the right directory is :)
timholy
force-pushed
the
teh/srccache_base
branch
from
bbc44e3 to
f68e610
Compare
timholy
force-pushed
the
teh/srccache_base
branch
from
f68e610 to
10c6b4a
Compare
|
Tested out-of-tree builds and |
When building Julia, this keeps track of the files used by
sysimg.jl, and then after building finishes it copies the contents of those files to a cache file<juliasrcdir>/usr/share/julia/base.cache. This allows Revise (and presumably other packages like Gallium) to detect changes that you've made to the source files that define Base. This makes it trivial to hack on Base without rebuilding Julia: you just sayRevise.track(Base), and any previous and future edits to the source files get incorporated into your running session automatically.In my opinion this change, in conjunction with timholy/Revise.jl#49, eliminates the last vestige of any kind of "dicey" behavior in Revise. (Previously, the need to parse the source to extract the list of
included files was a major wart, because there were many ways that parsing could fail.) AFAIK its only limitations now stem from those of the fix to #265.As a heads-up, once this merges I may start looking into what it will take to make Revise one of the "default packages" that gets installed & run by every user. (Configurably, of course.)