Refine liveness of phi and select #24035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If both inputs are rooted then we don't need to root the result. Rename `LoadRefinements` to `Refinements` since it's not load specific anymore. Fix #22421
yuyichao
force-pushed
the
yyc/codegen/select_phi
branch
from
9362dd0 to
5769cb0
Compare
|
Tests added. |
Keno
approved these changes
Oct 9, 2017
vtjnash
approved these changes
Oct 9, 2017
|
Bisection suggests that this is causing #24098 |
|
OK, I think the issue is that since the incomming value of phi node doesn't dominate the phi node, we can't simply refine phi to the incomming value since they might not be the "same value" anymore. I'll try to fix it later (hopefully 1-2 days) and if anyone need it urgently feel free to partially revert by commenting out julia/src/llvm-late-gc-lowering.cpp Lines 865 to 866 in 5769cb0 julia/src/llvm-late-gc-lowering.cpp Lines 870 to 871 in 5769cb0 |
vtjnash
added a commit
that referenced
this pull request
Oct 11, 2017
vtjnash
added a commit
that referenced
this pull request
Oct 11, 2017
yuyichao
pushed a commit
that referenced
this pull request
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both inputs are rooted then we don't need to root the result.
Rename
LoadRefinementstoRefinementssince it's not load specific anymore.Fix #22421
This is based on #23993 to reduce conflict.
llvmpasses test will come later.
The handling of
LiftPhiandLiftSelectisn't very pretty but hopefully good enough ;-p...