Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsets for test/statistics #23851

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Testsets for test/statistics #23851

merged 1 commit into from
Dec 11, 2017

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Sep 23, 2017

I'm kind of confused by the inference failure...

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Sep 23, 2017
@kshyatt
Copy link
Contributor Author

kshyatt commented Sep 23, 2017

@fredrikekre I think there's some inference problem i don't understand here, don't merge this without checking CI logs...

@fredrikekre
Copy link
Member

Could it be related to #23371?

@kshyatt
Copy link
Contributor Author

kshyatt commented Sep 23, 2017

Could be! I can see it locally on my mac...

@fredrikekre
Copy link
Member

Oh nice, no one has been able to reproduce locally before I think. Mind trying to reduce it and post in the issue?

@kshyatt
Copy link
Contributor Author

kshyatt commented Sep 23, 2017

Will do once I get home!

@kshyatt
Copy link
Contributor Author

kshyatt commented Dec 11, 2017

This is passing CI and approved.

@kshyatt kshyatt merged commit b5c6263 into master Dec 11, 2017
@kshyatt kshyatt deleted the ksh/tsstats branch December 11, 2017 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants