Remove some legacy gcroot codegen code #23568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLVM pass now figures this out automatically, so we no longer need to put it explicitly into the code. There's more cleanup to be done here, but I want to take this one step at a time, since this legacy code may have been hiding issues in the GC root placement pass.
|
Circle CI failure seems to be #23497. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLVM pass now figures this out automatically, so we no longer
need to put it explicitly into the code. There's more cleanup
to be done here, but I want to take this one step at a time,
since this legacy code may have been hiding issues in the GC
root placement pass.