Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia port of atan2 from Openlibm and add some tests. #23468

Merged
merged 3 commits into from
Oct 3, 2017

Conversation

pkofod
Copy link
Contributor

@pkofod pkofod commented Aug 26, 2017

Not tested for performance yet.

@ararslan ararslan added the maths Mathematical functions label Aug 26, 2017
@pkofod
Copy link
Contributor Author

pkofod commented Aug 31, 2017

Does anyone have an idea what the following test failure is about?

    FAILURE
Error in testset statistics:
Error During Test
  Got an exception of type LoadError outside of a @test
  LoadError: return type RowVector{Float64,Array{Float64,1}} does not match inferred return type Any
  Stacktrace:
   [1] include_relative(::Module, ::String) at ./loading.jl:464
   [2] eval(::Module, ::Any) at ./boot.jl:291
   [3] checked_add at ./checked.jl:170 [inlined]
   [4] length at ./range.jl:408 [inlined]
   [5] getindex at ./array.jl:770 [inlined]
   [6] choosetests(::Array{String,1}) at /usr/home/julia/worker/11rel-amd64/build/test/choosetests.jl:57
   [7] vect at ./array.jl:96 [inlined]
   [8] choosetests(::Array{String,1}) at /usr/home/julia/worker/11rel-amd64/build/test/choosetests.jl:151
   [9] choosetests(::Array{String,1}) at /usr/home/julia/worker/11rel-amd64/build/test/choosetests.jl:146
   [10] choosetests(::Array{String,1}) at /usr/home/julia/worker/11rel-amd64/build/test/choosetests.jl:148
   [11] choosetests(::Array{String,1}) at /usr/home/julia/worker/11rel-amd64/build/test/choosetests.jl:139
  while loading /usr/home/julia/worker/11rel-amd64/build/test/statistics.jl, in expression starting on line 177

@fredrikekre
Copy link
Member

#23371

@pkofod pkofod closed this Sep 20, 2017
@pkofod pkofod reopened this Sep 20, 2017
@pkofod
Copy link
Contributor Author

pkofod commented Sep 21, 2017

Travis has some test failures. They don't look nice, but I doubt they are related. #23796

@ararslan
Copy link
Member

ararslan commented Oct 1, 2017

@nanosoldier runbenchmarks("scalar", vs=":master")

@ararslan
Copy link
Member

ararslan commented Oct 1, 2017

Had to kick the server. @nanosoldier runbenchmarks("scalar", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@pkofod
Copy link
Contributor Author

pkofod commented Oct 1, 2017

Nanosoldier seems to be ok (? @simonbyrne )

@KristofferC KristofferC merged commit b3241d7 into JuliaLang:master Oct 3, 2017
@pkofod pkofod deleted the atan2 branch October 3, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maths Mathematical functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants