Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define Symbol(s::Symbol) = s for performance #23381

Merged
merged 1 commit into from
Aug 21, 2017
Merged

define Symbol(s::Symbol) = s for performance #23381

merged 1 commit into from
Aug 21, 2017

Conversation

rfourquet
Copy link
Member

Before, Symbol(:symbol) was calling the generic
Symbo(x...) method which in turns calls string(x...);
this is too slow for just returning the argument.

@rfourquet
define Symbol(s::Symbol) = s for performance
3cfd75b 
Before, `Symbol(:symbol)` was calling the generic
`Symbo(x...)` method which in turns calls `string(x...)`;
this is too slow for just returning the argument.
@rfourquet rfourquet added the performance Must go faster label Aug 21, 2017
@JeffBezanson
Copy link
Member

Heh, I have the same change in #23339.

@JeffBezanson JeffBezanson merged commit f679273 into master Aug 21, 2017
@JeffBezanson JeffBezanson deleted the rf/symbol-symbol branch August 21, 2017 20:39
ararslan pushed a commit that referenced this pull request Sep 11, 2017
@JeffBezanson @ararslan
Merge pull request #23381 from JuliaLang/rf/symbol-symbol
a3de4d7 
define Symbol(s::Symbol) = s for performance

Ref #23381
(cherry picked from commit f679273)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
@rfourquet @ararslan
define Symbol(s::Symbol) = s for performance
5800bca 
Before, `Symbol(:symbol)` was calling the generic
`Symbo(x...)` method which in turns calls `string(x...)`;
this is too slow for just returning the argument.

Ref #23381
(cherry picked from commit 3cfd75b)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
@rfourquet @vtjnash
define Symbol(s::Symbol) = s for performance
88407a5 
Before, `Symbol(:symbol)` was calling the generic
`Symbo(x...)` method which in turns calls `string(x...)`;
this is too slow for just returning the argument.

Ref #23381
(cherry picked from commit 3cfd75b)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
@rfourquet @ararslan
define Symbol(s::Symbol) = s for performance
3ea2cc1 
Before, `Symbol(:symbol)` was calling the generic
`Symbo(x...)` method which in turns calls `string(x...)`;
this is too slow for just returning the argument.

Ref #23381
(cherry picked from commit 3cfd75b)
ararslan pushed a commit that referenced this pull request Sep 16, 2017
@rfourquet @ararslan
define Symbol(s::Symbol) = s for performance
63474ef 
Before, `Symbol(:symbol)` was calling the generic
`Symbo(x...)` method which in turns calls `string(x...)`;
this is too slow for just returning the argument.

Ref #23381
(cherry picked from commit 3cfd75b)
ararslan pushed a commit that referenced this pull request Sep 18, 2017
@rfourquet @ararslan
define Symbol(s::Symbol) = s for performance
8e610d5 
Before, `Symbol(:symbol)` was calling the generic
`Symbo(x...)` method which in turns calls `string(x...)`;
this is too slow for just returning the argument.

Ref #23381
(cherry picked from commit 3cfd75b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rfourquet @JeffBezanson @ararslan @KristofferC