Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark julia threads as initialized #22987

Merged
merged 1 commit into from
Aug 3, 2017
Merged

mark julia threads as initialized #22987

merged 1 commit into from
Aug 3, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 27, 2017

This ensures that cfunction can see that Julia state is initialized on this thread, and thus letting it run in the newest world age.

I think this should fix JuliaPy/pyjulia#105, although I don't have pyjulia installed right now to test.

@vtjnash vtjnash requested a review from Keno July 27, 2017 22:04
@ararslan
Copy link
Member

Is it possible to add a test for this?

Keno
Keno approved these changes Jul 28, 2017
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to fix the pyjulia issue. Does need a test. Probably the embedding test is the right place to put this.

@Keno Keno mentioned this pull request Jul 28, 2017
Merged
@ararslan ararslan added the needs tests Unit tests are required for this change label Jul 28, 2017
@vtjnash vtjnash force-pushed the jn/init-threads-world branch from 3f900cd to d8d9135 Compare August 1, 2017 21:34
@vtjnash vtjnash removed the needs tests Unit tests are required for this change label Aug 1, 2017
@vtjnash vtjnash force-pushed the jn/init-threads-world branch from d8d9135 to 1538e61 Compare August 1, 2017 21:44
tkelman
tkelman reviewed Aug 1, 2017
View reviewed changes
examples/embedding/embedding.c Outdated
jl_array_t* x = jl_alloc_array_1d(array_type , 10);
jl_value_t* array_type = jl_apply_array_type((jl_value_t*)jl_float64_type, 1);
jl_array_t* x = jl_alloc_array_1d(array_type, 10);
// JL_GC_PUSH* is required here to ensures that `x` is not deleted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to ensure that

@vtjnash
mark julia threads as initialized
98a2d1d 
ensures that cfunction can see that Julia state is initialized on this thread

also upgrades the embedding/examples test to handle exceptions better
(e.g. to actually detect them) while testing for correctness
@vtjnash vtjnash force-pushed the jn/init-threads-world branch from 1538e61 to 98a2d1d Compare August 2, 2017 18:27
@vtjnash vtjnash merged commit a342e0f into master Aug 3, 2017
@vtjnash vtjnash deleted the jn/init-threads-world branch August 3, 2017 01:07
ararslan pushed a commit that referenced this pull request Sep 11, 2017
@vtjnash @ararslan
Merge pull request #22987 from JuliaLang/jn/init-threads-world
0804ec2 
mark julia threads as initialized for cfunction

Ref #22987
(cherry picked from commit a342e0f)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
@vtjnash @ararslan
mark julia threads as initialized
7c3af4f 
ensures that cfunction can see that Julia state is initialized on this thread

also upgrades the embedding/examples test to handle exceptions better
(e.g. to actually detect them) while testing for correctness

Ref #22987
(cherry picked from commit 98a2d1d)
vtjnash added a commit that referenced this pull request Sep 14, 2017
@vtjnash
mark julia threads as initialized
2b9a20f 
ensures that cfunction can see that Julia state is initialized on this thread

also upgrades the embedding/examples test to handle exceptions better
(e.g. to actually detect them) while testing for correctness

Ref #22987
(cherry picked from commit 98a2d1d)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
@vtjnash @ararslan
mark julia threads as initialized
8dbbf94 
ensures that cfunction can see that Julia state is initialized on this thread

also upgrades the embedding/examples test to handle exceptions better
(e.g. to actually detect them) while testing for correctness

Ref #22987
(cherry picked from commit 98a2d1d)
ararslan pushed a commit that referenced this pull request Sep 16, 2017
@vtjnash @ararslan
mark julia threads as initialized
516dbf3 
ensures that cfunction can see that Julia state is initialized on this thread

also upgrades the embedding/examples test to handle exceptions better
(e.g. to actually detect them) while testing for correctness

Ref #22987
(cherry picked from commit 98a2d1d)
ararslan pushed a commit that referenced this pull request Sep 18, 2017
@vtjnash @ararslan
mark julia threads as initialized
c1cbc98 
ensures that cfunction can see that Julia state is initialized on this thread

also upgrades the embedding/examples test to handle exceptions better
(e.g. to actually detect them) while testing for correctness

Ref #22987
(cherry picked from commit 98a2d1d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MethodError when using (indirectly) StaticArrays
4 participants
@vtjnash @ararslan @Keno @tkelman