Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix codegen bug in === on two SimpleVectors #22946

Merged
merged 1 commit into from
Jul 25, 2017
Merged

fix codegen bug in === on two SimpleVectors #22946

merged 1 commit into from
Jul 25, 2017

Conversation

JeffBezanson
Copy link
Member

Found while working on #22193. String and SimpleVector are the two types marked as mutable but treated as immutable by === (only true for String after #22193). Not a big deal for SimpleVector, since it's very rarely used; might as well just fix the bug here.

@JeffBezanson JeffBezanson added backport pending 0.6 bugfix This change fixes an existing bug compiler:codegen Generation of LLVM IR and native code labels Jul 25, 2017
@JeffBezanson JeffBezanson merged commit 9186ae4 into master Jul 25, 2017
@JeffBezanson JeffBezanson deleted the jb/svecegal branch July 25, 2017 16:10
ararslan pushed a commit that referenced this pull request Sep 11, 2017
@JeffBezanson @ararslan
Merge pull request #22946 from JuliaLang/jb/svecegal
123fb14 
fix codegen bug in `===` on two `SimpleVector`s

Ref #22946
(cherry picked from commit 9186ae4)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
@JeffBezanson @ararslan
fix codegen bug in === on two SimpleVectors
93174aa 
Ref #22946
(cherry picked from commit 2fca4d3)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
@JeffBezanson @vtjnash
fix codegen bug in === on two SimpleVectors
97a677c 
Ref #22946
(cherry picked from commit 2fca4d3)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
@JeffBezanson @ararslan
fix codegen bug in === on two SimpleVectors
1dc8ee4 
Ref #22946
(cherry picked from commit 2fca4d3)
ararslan pushed a commit that referenced this pull request Sep 16, 2017
@JeffBezanson @ararslan
fix codegen bug in === on two SimpleVectors
7994c64 
Ref #22946
(cherry picked from commit 2fca4d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @ararslan