Add NEWS and docs for the new inlining algorithm #22775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jul 12, 2017
doc/src/devdocs/inference.md
Outdated
| cases. For example, an `:invoke` expression (a call for which all | ||
| input and output types were inferred in advance) is assigned a fixed | ||
| cost (currently 20 cycles). In contrast, a `:call` expression, for | ||
| other than intrinsics/builtins, indicates that the call will require |
There was a problem hiding this comment.
for functions other than ?
vtjnash
approved these changes
Jul 13, 2017
vtjnash
reviewed
Jul 13, 2017
| @@ -0,0 +1,98 @@ | |||
|
|
|||
| # Inference | |||
There was a problem hiding this comment.
Perhaps we should add links to https://juliacomputing.com/blog/2016/04/04/inference-convergence.html and https://juliacomputing.com/blog/2017/05/15/inference-converage2.html to describe the overall structure?
I should also probably add a description of #21933 here too, later, when I get a chance.
timholy
force-pushed
the
teh/docs_inlining
branch
from
9d6e5bf to
70dfb6d
Compare
|
Hmm, link is broken. Any idea what I missed? |
|
I see there's a blank line at the top of |
|
Fixed in 9c1d1b8 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also included a number of useful tips I've accumulated while hacking on
inference.jl. Hopefully this will save head-scratching for future generations. (Others are encouraged to add to this!)[ci skip]