fix shell mode interpolation while allowing special chars in commands #22409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit cherry-picks cleanly onto master, so maybe I should have done it there, but I did the work on the 0.6 release branch, so we can do a forward cherry-pick later. |
StefanKarpinski
force-pushed
the
sk/fixrepl
branch
from
bcb2640 to
7062315
Compare
StefanKarpinski
force-pushed
the
sk/fixrepl
branch
from
7062315 to
6eaf550
Compare
|
I have no idea what the Windows failure is – something related to loading libfftw3? |
|
It downloads the nightly which may not have fftw library anymore? Shouldn't be a problem on master. |
|
Ah, ok. I guess I'll close this and reopen against master. |
It'll probably show up again on the next backport release but I assume someone else |
|
Yes, @tkelman knows better than I do how to test for Windows on non-master. |
|
fixed that in my backport branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22176, see also #20494 and #20482