RFC: Avoid setting the RPATH for LLVM #22352

ararslan · 2017-06-13T04:46:55Z

Some of the changes in #21788 adversely affected Linux. This partially reverts/restructures some of the changes.

ararslan · 2017-06-13T04:47:15Z

jlbuild · 2017-06-13T04:47:20Z

Status of `1c973df` builds:

Builder Name	Nuke	Build	Download
linux32	COMPLETE	ERRORED	N/A
linux64	COMPLETE	ERRORED	N/A
linuxaarch64	COMPLETE	COMPLETE	Download
linuxarmv7l	COMPLETE	COMPLETE	Download
linuxppc64le	COMPLETE	COMPLETE	Download
osx64	COMPLETE	COMPLETE	Download
win32	CANCELED	N/A	N/A
win64	COMPLETE	ERRORED	N/A

vtjnash

lgtm

vtjnash · 2017-06-13T05:09:20Z

I don't know if this was related to any of your PRs, but I noticed we're creating some of these variables as normal recursively expanded ones, instead of as simply-expanded ones. We may want to add this patch to declare these variables as being of type := before using them.

--- a/deps/llvm.mk
+++ b/deps/llvm.mk
@@ -60,6 +60,12 @@ else
 LLVM_TARGETS := host;NVPTX
 endif
 
+LLVM_CFLAGS :=
+LLVM_CXXFLAGS :=
+LLVM_CPPFLAGS :=
+LLVM_LDFLAGS :=
+LLVM_CMAKE :=
+
 # Allow adding LLVM specific flags
 LLVM_CFLAGS += $(CFLAGS)
 LLVM_CXXFLAGS += $(CXXFLAGS)

ararslan · 2017-06-13T05:25:55Z

No, I think the variable declaration was a preexisting condition. I've added your patch as a separate commit. Thanks!

tkelman · 2017-06-13T05:31:54Z

Why is llvm picky about this? leave a comment by the CMAKE_COMMON saying not to put anything rpath related there for this reason, so we aren't tempted to do this again by accident?

ararslan · 2017-06-13T05:51:46Z

Why is llvm picky about this?

¯\_(ツ)_/¯ It isn't on FreeBSD, which is why I never noticed this

leave a comment [...] so we aren't tempted to do this again by accident?

Good idea, will do once CI is done so I don't end up just queuing up a ton of builds here

Edit: Done, squashed into first commit

ararslan · 2017-06-13T17:43:21Z

deps/tools/common.mk

 ifeq ($(OS),FreeBSD)
 ifneq ($(GCCPATH),)
-INSTALL_RPATH := "\$$ORIGIN:$(GCCPATH)"
+CMAKE_COMMON += -DCMAKE_INSTALL_RPATH="\$$ORIGIN:$(GCCPATH)"


This actually ends up duplicating the RPATH specification on FreeBSD, though I nuked everything, rebuilt from scratch, and tested everything, and things are fine.

This reverts commit 8b8fa11. Ref: JuliaLang#22352

Tweak the order of libgcc_s in DT_NEEDED. Make FreeBSD do not require `BUILD_CUSTOM_LIBCXX`. See also: JuliaLang#21788, JuliaLang#22352

Tweak the order of libgcc_s in DT_NEEDED on FreeBSD so that building on FreeBSD does not require `BUILD_CUSTOM_LIBCXX`. See also: #21788, #22352

Tweak the order of libgcc_s in DT_NEEDED on FreeBSD so that building on FreeBSD does not require `BUILD_CUSTOM_LIBCXX`. See also: JuliaLang#21788, JuliaLang#22352

Ref #22352 (cherry picked from commit 8b8fa11)

Ref #22352 (cherry picked from commit 9e37db0)

Tweak the order of libgcc_s in DT_NEEDED on FreeBSD so that building on FreeBSD does not require `BUILD_CUSTOM_LIBCXX`. See also: #21788, #22352 Ref #22656 (cherry picked from commit d90c215)

Ref #22352 (cherry picked from commit 8b8fa11)

Ref #22352 (cherry picked from commit 9e37db0)

Tweak the order of libgcc_s in DT_NEEDED on FreeBSD so that building on FreeBSD does not require `BUILD_CUSTOM_LIBCXX`. See also: #21788, #22352 Ref #22656 (cherry picked from commit d90c215)

Ref #22352 (cherry picked from commit 8b8fa11)

Ref #22352 (cherry picked from commit 9e37db0)

Tweak the order of libgcc_s in DT_NEEDED on FreeBSD so that building on FreeBSD does not require `BUILD_CUSTOM_LIBCXX`. See also: #21788, #22352 Ref #22656 (cherry picked from commit d90c215)

Ref #22352 (cherry picked from commit 8b8fa11)

Ref #22352 (cherry picked from commit 9e37db0)

Tweak the order of libgcc_s in DT_NEEDED on FreeBSD so that building on FreeBSD does not require `BUILD_CUSTOM_LIBCXX`. See also: #21788, #22352 Ref #22656 (cherry picked from commit d90c215)

ararslan added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Jun 13, 2017

ararslan requested a review from vtjnash June 13, 2017 04:46

vtjnash approved these changes Jun 13, 2017

View reviewed changes

ararslan and others added 2 commits June 12, 2017 23:53

Avoid setting the RPATH for LLVM

8b8fa11

Declare LLVM Make variables as simply-expanded, not recursively expanded

9e37db0

ararslan force-pushed the aa/unbreak-rpath branch from 90cfa81 to 9e37db0 Compare June 13, 2017 06:53

vtjnash mentioned this pull request Jun 13, 2017

installing julia on Ubuntu with bug #22358

Closed

ararslan changed the title ~~WIP: Avoid setting the RPATH for LLVM~~ RFC: Avoid setting the RPATH for LLVM Jun 13, 2017

Keno approved these changes Jun 13, 2017

View reviewed changes

ararslan commented Jun 13, 2017

View reviewed changes

ararslan merged commit 823d3b6 into master Jun 13, 2017

ararslan deleted the aa/unbreak-rpath branch June 13, 2017 17:50

iblislin added a commit to iblislin/julia that referenced this pull request Jul 2, 2017

Revert "Avoid setting the RPATH for LLVM"

4015c83

This reverts commit 8b8fa11. Ref: JuliaLang#22352

iblislin added a commit to iblislin/julia that referenced this pull request Jul 2, 2017

FreeBSD: propose a simpler way to deal with libgcc_s

d0a7b1e

Tweak the order of libgcc_s in DT_NEEDED. Make FreeBSD do not require `BUILD_CUSTOM_LIBCXX`. See also: JuliaLang#21788, JuliaLang#22352

iblislin added a commit to iblislin/julia that referenced this pull request Jul 2, 2017

FreeBSD: propose a simpler way to deal with libgcc_s

fba8996

Tweak the order of libgcc_s in DT_NEEDED. Make FreeBSD do not require `BUILD_CUSTOM_LIBCXX`. See also: JuliaLang#21788, JuliaLang#22352

ararslan pushed a commit that referenced this pull request Jul 10, 2017

A simpler way to deal with libgcc_s on FreeBSD (#22656)

d90c215

Tweak the order of libgcc_s in DT_NEEDED on FreeBSD so that building on FreeBSD does not require `BUILD_CUSTOM_LIBCXX`. See also: #21788, #22352

ararslan added a commit that referenced this pull request Apr 25, 2018

Avoid setting the RPATH for LLVM

aee82d2

Ref #22352 (cherry picked from commit 8b8fa11)

ararslan pushed a commit that referenced this pull request Apr 25, 2018

Declare LLVM Make variables as simply-expanded, not recursively expanded

52ef91f

Ref #22352 (cherry picked from commit 9e37db0)

ararslan added a commit that referenced this pull request May 2, 2018

Avoid setting the RPATH for LLVM

2f343e2

Ref #22352 (cherry picked from commit 8b8fa11)

ararslan pushed a commit that referenced this pull request May 2, 2018

Declare LLVM Make variables as simply-expanded, not recursively expanded

ae4dc95

Ref #22352 (cherry picked from commit 9e37db0)

ararslan added a commit that referenced this pull request May 8, 2018

Avoid setting the RPATH for LLVM

4ebc476

Ref #22352 (cherry picked from commit 8b8fa11)

ararslan pushed a commit that referenced this pull request May 8, 2018

Declare LLVM Make variables as simply-expanded, not recursively expanded

a127abc

Ref #22352 (cherry picked from commit 9e37db0)

ararslan added a commit that referenced this pull request May 27, 2018

Avoid setting the RPATH for LLVM

4530b55

Ref #22352 (cherry picked from commit 8b8fa11)

ararslan pushed a commit that referenced this pull request May 27, 2018

Declare LLVM Make variables as simply-expanded, not recursively expanded

51da3b5

Ref #22352 (cherry picked from commit 9e37db0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RFC: Avoid setting the RPATH for LLVM #22352

RFC: Avoid setting the RPATH for LLVM #22352

ararslan commented Jun 13, 2017

ararslan commented Jun 13, 2017

jlbuild commented Jun 13, 2017 •

edited

Loading

vtjnash left a comment

vtjnash commented Jun 13, 2017

ararslan commented Jun 13, 2017

tkelman commented Jun 13, 2017

ararslan commented Jun 13, 2017 •

edited

Loading

ararslan Jun 13, 2017

ararslan Jun 13, 2017

RFC: Avoid setting the RPATH for LLVM #22352

RFC: Avoid setting the RPATH for LLVM #22352

Conversation

ararslan commented Jun 13, 2017

ararslan commented Jun 13, 2017

jlbuild commented Jun 13, 2017 • edited Loading

Status of 1c973df builds:

vtjnash left a comment

Choose a reason for hiding this comment

vtjnash commented Jun 13, 2017

ararslan commented Jun 13, 2017

tkelman commented Jun 13, 2017

ararslan commented Jun 13, 2017 • edited Loading

ararslan Jun 13, 2017

Choose a reason for hiding this comment

ararslan Jun 13, 2017

Choose a reason for hiding this comment

jlbuild commented Jun 13, 2017 •

edited

Loading

Status of `1c973df` builds:

ararslan commented Jun 13, 2017 •

edited

Loading