validate ccall nargs #22344
Merged
validate ccall nargs #22344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows concisely writing reliable test_throws tests
vtjnash
added
error handling
|
Is it ok to have this now be an error on 0.6, or perhaps in 0.6.1? |
|
This requires removing a deprecation to implement (although if necessary, we could make the deprecation more accurate, there's a small number of cases – like the one in Rmath – that it couldn't currently detect). |
|
Will this close #20129? |
|
That's too late to make it an error in 0.6 IMHO, the RCs shouldn't introduce breaking changes. Same for 0.6.1, which is supposed to fix bugs without introducing any new failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the deprecation warning ("ccall: wrong number of arguments to C function" that was added in v0.6, since making this an error immediately broke too many packages) into a syntax error, rather than emitting malformed syntax.
closes #22334