Implement svdx(Number, Number) #22195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jun 2, 2017
base/linalg/svd.jl
Outdated
| @@ -231,6 +232,10 @@ function svdfact(A::StridedMatrix{TA}, B::StridedMatrix{TB}) where {TA,TB} | |||
| S = promote_type(Float32, typeof(one(TA)/norm(one(TA))),TB) | |||
| return svdfact!(copy_oftype(A, S), copy_oftype(B, S)) | |||
| end | |||
| # This method can be heavily optimized but it is probably not cirtical | |||
Sacha0
reviewed
Jun 2, 2017
| @@ -30,6 +30,10 @@ end | |||
| convert(::Type{Factorization{T}}, F::Factorization{T}) where {T} = F | |||
| inv(F::Factorization{T}) where {T} = A_ldiv_B!(F, eye(T, size(F,1))) | |||
|
|
|||
| Base.hash(F::Factorization, h::UInt) = mapreduce(f -> hash(getfield(F, f)), hash, h, fieldnames(F)) | |||
| Base.:(==)( F::T, G::T) where {T<:Factorization} = all(f -> getfield(F, f) == getfield(G, f), fieldnames(F)) | |||
There was a problem hiding this comment.
Guessing the extra spaces are for alignment? :)
Sacha0
reviewed
Jun 2, 2017
base/linalg/svd.jl
Outdated
| # This method can be heavily optimized but it is probably not critical | ||
| # and might introduce bugs or inconsistencies relative to the 1x1 matrix | ||
| # version | ||
| svdfact(x::Number, y::Number) = svdfact(fill(x,1,1), fill(y,1,1)) |
There was a problem hiding this comment.
Missing spaces between function arguments? (Spaces exist in the similar method definition below.)
Sacha0
reviewed
Jun 2, 2017
test/linalg/svd.jl
Outdated
| @test svdfact(x,y) == svdfact(fill(x,1,1), fill(y,1,1)) | ||
| @test svdvals(x,y) == first(svdvals(fill(x,1,1), fill(y,1,1))) | ||
| @test svd(x,y) == first.(svd(fill(x,1,1), fill(y,1,1))) | ||
| end |
There was a problem hiding this comment.
We should choose a convention for spaces separating function arguments and use it consistently :).
Make svd(x::Number) return numbers Implement hash, isequal, and == for Factorizations
|
How many of the other factorizations do we do this for? |
|
In theory, we do all of them, see #1871, but some of them are broken, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular demand. Also
Make
svd(x::Number)return numbersImplement
hash,isequal, and==forFactorizationscc @alanedelman