Fix bash on windows build and add instructions #22074

mikewl · 2017-05-26T13:14:54Z

For a smooth build of Julia in bash on windows $$PATH needs to be in quotes as windows paths with spaces are in the path.
Simple instructions were also added to help users wanting to build Julia in bash on windows. Some dependencies like python 2.7 are not by default installed.

Quotes around $$PATH are necessary for bash on windows as the default path now includes windows paths which include spaces.

tkelman · 2017-05-26T13:38:42Z

README.windows.md

@@ -436,3 +436,10 @@ running the resulting installer.
   inspect the list of loaded DLLs for bash, mintty, or another persistent
   process used to drive the build. Essentially *any* DLL outside of the Windows
   System directory is potential BLODA.
+
+   ### Compiling for Bash on windows
+   Bash on windows is an unsupported platform. However, compilation of julia is possible and functional. The packages required differ  from standard ubuntu compilation as some packages are not installed by default in the bash on windows ubuntu image.


please follow line length conventions consistent with the rest of this file

tkelman · 2017-05-26T13:39:47Z

README.windows.md

+   ### Compiling for Bash on windows
+   Bash on windows is an unsupported platform. However, compilation of julia is possible and functional. The packages required differ  from standard ubuntu compilation as some packages are not installed by default in the bash on windows ubuntu image.
+
+   The missing packages are `byacc texinfo python-minimal automake`. With these installed and the standard ubuntu packages dependancies and julia currently compile without issue. The line below can be copied into your terminal to install all required packages.


julia and its dependencies shouldn't need byacc, texinfo, or automake

All those dependencies were sourced as Julia compiled.
byacc is needed for gmp, I can't remember where the other two were called but I started on a clean bash on windows install for this and those were the packages it told me mid compilation were missing

byacc should never be needed if you build from a release tarball

tkelman · 2017-05-26T14:49:14Z

README.windows.md

+
+   ### Compiling for Bash on windows
+   Bash on windows is an unsupported platform. However, compilation of julia is
+   possible and functional. The packages required differ from standard ubuntu


they shouldn't differ at all. how could we need byacc, texinfo, or automake when nothing we build needs them?

Might be a filesystem bug – these could get triggered by having incorrect file timestamps.

Busy uninstalling and reinstalling. Will make again and get the logs where it errors asking for those three.

fredrikekre

Windows should probably be upper case, as per the rest of the file.

fredrikekre · 2017-05-26T14:49:39Z

README.windows.md

@@ -436,3 +436,17 @@ running the resulting installer.
   inspect the list of loaded DLLs for bash, mintty, or another persistent
   process used to drive the build. Essentially *any* DLL outside of the Windows
   System directory is potential BLODA.
+
+   ### Compiling for Bash on windows


This is indented 2 spaces too much (it becomes a subsection)

note to self: never edit directly in github ever again

fredrikekre · 2017-05-26T14:50:18Z

README.windows.md

+   compilation as some packages are not installed by default in the bash on
+   windows ubuntu image.
+
+   The missing packages are `byacc texinfo python-minimal automake`. With these


byacc, texinfo, python-minimal and automake

fixed that up as well as the other indentation issue

Sacha0 · 2017-05-26T16:48:39Z

README.windows.md

+   windows ubuntu image.
+
+   The missing packages are `byacc` `texinfo` `python-minimal` `automake`.
+   With these installed and the standard ubuntu packages dependancies and


"dependancies" -> "dependencies"?

Sacha0 · 2017-05-26T16:51:25Z

README.windows.md

+
+   The missing packages are `byacc` `texinfo` `python-minimal` `automake`.
+   With these installed and the standard ubuntu packages dependancies and
+   julia currently compile without issue. The line below can be copied


Perhaps rephrase the "With these installed" sentence? Its meaning is not clear.

Sacha0

Thanks for the contribution @mikewl! :) Expanding on frederikekre's comment, Julia and Ubuntu might also use capitalization.

mikewl · 2017-05-27T00:50:53Z

aclocal is why I added autotools and patchelf is asking for it. Should I change it to autconf instead? GMP is still asking for yacc and mpfr docs want makeinfo which is why I chose texinfo.

I will address @Sacha0's comments in the morning. Compiling without -j n takes far too long to compile all dependencies on my laptop!

tkelman · 2017-05-27T01:08:43Z

patchelf, gmp, and mpfr should need none of those things when building anywhere else. are you using the latest test version of wsl? they may have fixed the issue already.

mikewl · 2017-05-27T01:31:55Z

On the latest build in the fast ring with a clean install of wsl.

tkelman · 2017-05-27T01:49:13Z

Then needing anything to build that isn't needed on normal Linux should be reported as a bug to WSL.

mikewl · 2017-05-27T02:30:55Z

I grabbed the ubuntu docker image which is as bare as it gets. Busy compiling now just in case. Will file the bug once I have confirmed that the error is isolated to wsl.

tkelman · 2017-05-27T02:37:33Z

as @vtjnash suggested above in a now-hidden comment,

Might be a filesystem bug – these could get triggered by having incorrect file timestamps.

can happen when autotools thinks you've changed something in a file that you haven't actually touched, and tries to regenerate things that it doesn't need to do if you're building from a release

mikewl · 2017-05-27T03:47:52Z

I submitted the bug at microsoft/WSL#2162

musm · 2017-06-02T07:24:41Z

would be nice to get this working

tkelman · 2017-06-02T07:40:19Z

Yes, Microsoft should fix its bugs. Until it actually works the way it's supposed to, we shouldn't be encouraging anyone to use Julia on it.

tkelman · 2017-06-02T07:42:20Z

The makefile changes here should be fine on their own though.

mikewl · 2017-06-02T07:47:44Z

Should I nuke the instructions and just leave the simple makefile changes?

tkelman · 2017-06-02T07:51:20Z

I'd merge that part now. On the other part, were you building in /mnt/ or /home/ ?

mikewl · 2017-06-02T07:52:37Z

/mnt/
It probably is the cp -p bug mentioned in the related issue

mikewl · 2017-06-02T07:57:43Z

The build in /home/ only works with the " being placed around the $$PATH variable though. Unless you disable including the windows path in bash on windows. export doesn't like spaces in the PATH vartiable

tkelman · 2017-06-02T07:59:15Z

We could say "don't build in /mnt/" until they've fixed that. depends how long it's expected to be broken for. I read that the latest version will let you install WSL in non C locations if you want, so there's very little reason to be using /mnt/

mikewl · 2017-06-02T08:11:22Z

The reason I was using /mnt/ was so I could easily edit the files. It's a PITA to edit files inside /home/ with standard windows tools. /mnt/ works perfectly for editing but there are the related issues for now.
I removed the docs portion for now. This is niche beyond niche at this point anyway so somebody with interest would probably find this issue.

tkelman · 2017-06-02T08:24:42Z

Then don't use windows tools to edit? cygwin can get time stamps right, if WSL can't then it still needs a lot of work before it's usable.

tkelman · 2017-06-02T10:07:08Z

where is travis on this?

mikewl · 2017-06-02T11:48:16Z

I have absolutely no idea!
Do I need to do something specific to get travis to run now?

tkelman · 2017-06-02T11:50:51Z

Don't think there's anything you can do on your side. If Travis worked via a webhook I could check that in the settings, but it doesn't. It passed before, right?

mikewl · 2017-06-02T12:36:05Z

Now that I think about it, I don't think Travis ever ran on it...

musm · 2017-07-03T19:47:42Z

bump

musm · 2017-07-03T19:53:37Z

Looks like this just needs a rebase and an updated PR title

tkelman · 2017-07-16T14:50:28Z

rebased and merged in #22705, WSL note adjusted in #22821

Add quotes around $$PATH in llvm.mk

16da55f

Quotes around $$PATH are necessary for bash on windows as the default path now includes windows paths which include spaces.

mikewl force-pushed the mikewl/uow branch from 401b1ba to 688eac9 Compare May 26, 2017 13:24

tkelman reviewed May 26, 2017

View reviewed changes

mikewl force-pushed the mikewl/uow branch from 688eac9 to d454a3d Compare May 26, 2017 14:40

tkelman reviewed May 26, 2017

View reviewed changes

fredrikekre reviewed May 26, 2017

View reviewed changes

mikewl force-pushed the mikewl/uow branch from d454a3d to 6ad9cd4 Compare May 26, 2017 15:04

Sacha0 reviewed May 26, 2017

View reviewed changes

kshyatt added building Build system, or building Julia or its dependencies docs This change adds or pertains to documentation system:windows Affects only Windows labels May 27, 2017

mikewl force-pushed the mikewl/uow branch from 6ad9cd4 to dd33d59 Compare May 27, 2017 01:02

mikewl force-pushed the mikewl/uow branch from dd33d59 to 16da55f Compare June 2, 2017 08:08

tkelman closed this Jun 2, 2017

tkelman reopened this Jun 2, 2017

tkelman approved these changes Jun 2, 2017

View reviewed changes

tkelman closed this Jun 2, 2017

tkelman reopened this Jun 2, 2017

musm mentioned this pull request Jul 7, 2017

Quote PATH in llvm.mk for paths with spaces #22705

Merged

tkelman closed this Jul 16, 2017

Fix bash on windows build and add instructions #22074

Fix bash on windows build and add instructions #22074

Conversation

mikewl commented May 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fredrikekre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sacha0 left a comment

Choose a reason for hiding this comment

mikewl commented May 27, 2017

tkelman commented May 27, 2017

mikewl commented May 27, 2017

tkelman commented May 27, 2017

mikewl commented May 27, 2017

tkelman commented May 27, 2017

mikewl commented May 27, 2017

musm commented Jun 2, 2017

tkelman commented Jun 2, 2017

tkelman commented Jun 2, 2017

mikewl commented Jun 2, 2017

tkelman commented Jun 2, 2017

mikewl commented Jun 2, 2017

mikewl commented Jun 2, 2017

tkelman commented Jun 2, 2017

mikewl commented Jun 2, 2017

tkelman commented Jun 2, 2017

tkelman commented Jun 2, 2017

mikewl commented Jun 2, 2017

tkelman commented Jun 2, 2017

mikewl commented Jun 2, 2017

musm commented Jul 3, 2017

musm commented Jul 3, 2017

tkelman commented Jul 16, 2017