give an error instead of a segfault on broken references in precompiled modules #21785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed modules This can happen for example if another package creates something unpredictably with `eval`, which then doesn't exist when trying to load an (incorrectly) precompiled package that depends on it.
JeffBezanson
added
bugfix
|
nah, this is supposed to segfault here – it's much friendlier getting it here than discovering it later in the gc. |
|
Ok, if we really can't recover from this then we can print this message and call |
|
sure, that's fine. that's roughly why there's an assert right after these, although it could certainly use a better message than SIGSEGV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From JuliaData/NamedTuples.jl#27 (comment).