Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for authors #21706

Merged
merged 1 commit into from
May 6, 2017
Merged

Add example for authors #21706

merged 1 commit into from
May 6, 2017

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented May 5, 2017

No description provided.

@kshyatt kshyatt added docs This change adds or pertains to documentation libgit2 The libgit2 library or the LibGit2 stdlib module labels May 5, 2017
@kshyatt kshyatt requested a review from ararslan May 5, 2017 03:47
@ararslan
Copy link
Member

ararslan commented May 5, 2017

Might be nice to include a close(repo_file), but not really necessary since it isn't a doctest or real code or anything. Other than that, LGTM. Nice work!

Sacha0
Sacha0 approved these changes May 5, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo ararslan's comment! :) (Absent objections, requests for time, or someone beating me to it, I plan to merge this tomorrow morning. Best!)

@kshyatt kshyatt merged commit 11724ff into master May 6, 2017
@kshyatt kshyatt deleted the ksh/authors branch May 6, 2017 16:12
tkelman pushed a commit that referenced this pull request May 14, 2017
@kshyatt @tkelman
Add example for authors
9a47376 
(cherry picked from commit 3cfb989)
ref #21706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

@ararslan ararslan Awaiting requested review from ararslan

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kshyatt @ararslan @Sacha0 @tkelman