inference abstract-iteration bug #21690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most notably in Core.Inference, this may cause the addition of bad edges and suboptimal results
ensures that abstract_iteration gets better information, and that specialization can compile these methods ahead-of-time
JeffBezanson
approved these changes
May 5, 2017
|
can the bug be tested? |
tkelman
pushed a commit
that referenced
this pull request
May 14, 2017
most notably in Core.Inference, this may cause the addition of bad edges and suboptimal results (cherry picked from commit 49c1910) ref #21690 inference: improve function call signatures ensures that abstract_iteration gets better information, and that specialization can compile these methods ahead-of-time (cherry picked from commit 0250e4f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lots of code movement to help make inference itself more easily inferable (and thus more reliably faster), but the main bugfix is https://github.com/JuliaLang/julia/pull/21690/files#diff-c0d983631c937ee5acfd0137cd7332deR1466