Test some libgit2 warnings

[kshyatt]

Re #21560.

[tkelman]

yay thank you, that works locally

there are also the readuntil(IO,AbstractString) will perform poorly ones but I think @omus added those

[kshyatt]

Glad it works, when I get back I can take a look at the readstring ones if no one else has.

…

On Wed, Apr 26, 2017, 9:45 AM Tony Kelman ***@***.***> wrote: ***@***.**** approved this pull request. yay thank you, that works locally there are also the readuntil(IO,AbstractString) will perform poorly ones but I think @omus <https://github.com/omus> added those — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21566 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAyk46RvKElYr9MQpm2g6Pjp51qeO_tJks5rz3ShgaJpZM4NJH-j> .

[omus]

there are also the readuntil(IO,AbstractString) will perform poorly ones but I think @omus added those

Was definitely me. Will eventually be resolved by #20621

[tkelman]

Right, but if that's post-0.6 material, will it be possible to do something quick with test_warn so these tests are quieter for the lifetime of the release-0.6 branch?

[omus]

The warning is coming from https://github.com/JuliaLang/julia/blob/master/test/TestHelpers.jl#L95. We could either silence the warning by redirecting STDERR at this point or adding a keyword into readuntil which stops the warning from being reported. I don't think we can use @test_warn as I'm unsure how it would handle multiple warnings from the same function call

[kshyatt]

Is the AV failure real? Can we merge?

[tkelman]

it's #16555