-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to add refspecs and tests to view fetchspecs #21227
Conversation
docstrings would be informative here (and also a mention in the push docstring maybe?) |
Added docs with examples. The doc build succeeds locally for me. |
You may need to [`close`](@ref) and reopen the `GitRemote` | ||
in question after updating its push refspecs in order for | ||
the change to take effect and for calls to [`push`](@ref) | ||
to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is something we could handle behind the scenes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan is to get rid of close
entirely so ideally soon we won't have to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
and very minor wording tweak
Good to squash and merge? |
This should let you set a push refspec and have
LibGit2.push
do things.