Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to add refspecs and tests to view fetchspecs #21227

Merged
merged 3 commits into from
Mar 31, 2017
Merged

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Mar 29, 2017

This should let you set a push refspec and have LibGit2.push do things.

@kshyatt kshyatt added libgit2 The libgit2 library or the LibGit2 stdlib module test This change adds or pertains to unit tests labels Mar 29, 2017
@tkelman
Copy link
Contributor

tkelman commented Mar 29, 2017

docstrings would be informative here (and also a mention in the push docstring maybe?)

@kshyatt
Copy link
Contributor Author

kshyatt commented Mar 30, 2017

Added docs with examples. The doc build succeeds locally for me.

You may need to [`close`](@ref) and reopen the `GitRemote`
in question after updating its push refspecs in order for
the change to take effect and for calls to [`push`](@ref)
to work.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is something we could handle behind the scenes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is to get rid of close entirely so ideally soon we won't have to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

and very minor wording tweak
@kshyatt
Copy link
Contributor Author

kshyatt commented Mar 30, 2017

Good to squash and merge?

@tkelman tkelman merged commit cded1db into master Mar 31, 2017
@tkelman tkelman deleted the ksh/refspecs branch March 31, 2017 00:28
@iamnapo iamnapo mentioned this pull request Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants