Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test for mapslices #21181

Merged
merged 2 commits into from
Mar 28, 2017
Merged

Add missing test for mapslices #21181

merged 2 commits into from
Mar 28, 2017

Conversation

mbauman
Copy link
Member

@mbauman mbauman commented Mar 27, 2017

Followup from #21133

Followup from #21133
@ararslan ararslan added linear algebra Linear algebra test This change adds or pertains to unit tests labels Mar 27, 2017
test/arrayops.jl Outdated
@@ -958,7 +958,7 @@ end
@test m[1,2] == ([2,4],)

# issue #21123
@test mapslices(nnz, speye(3), 1) == [1, 1, 1]
@test mapslices(nnz, speye(3), 1) == [1 1 1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, the dangers of not having a @test...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞

@vchuravy vchuravy merged commit 9163e67 into master Mar 28, 2017
@vchuravy vchuravy deleted the mbauman-patch-1 branch March 28, 2017 02:38
@iamnapo iamnapo mentioned this pull request Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants