fix shape corner cases in sparse broadcast!(f, C, A, B) #20937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, fix zero-preserving sparse broadcast!(f, C, A, B) where C's shape does not match the broadcast shape of A and B. Strengthen associated tests.
… A, B). Specifically, fix not-zero-preserving sparse broadcast!(f, C, A, B) where C's shape does not match the broadcast shape of A and B. Strengthen associated tests.
Sacha0
added
bugfix
tkelman
approved these changes
Mar 8, 2017
|
Thanks Tony! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparse
broadcast!(f, C, A, B)produces incorrect results where destinationC's shape does not match the broadcast-shape of sourcesAandB. (This issue is the analog of that described and fixed in #19986 forbroadcast!(f, C, A).) This pull request fixes that issue and strengthens associated tests (first commit covers zero-preserving functions, and the second commit not-zeropreserving functions). Best!