-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse dots everywhere #20540
parse dots everywhere #20540
Conversation
Rebased and now passing CI. Thoughts on how best to test this? (Beyond tossing an instance or two in |
hm, looks like this could be breaking for floating point literals without leading 0s? |
Yes: |
I don't think that implementing I think we should probably parse |
This PR is breaking because it changes the parsing of |
Agreed.
This pull request does not implement
Best! |
The problem is that even just making |
(Ref. #19089) |
This pull request makes
op.
parse like.op
, enabling backwards compatibility (as pointed out in #20249 (comment)) in case we revisit the dot position consistency question. Best!