Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versioned UnicodeData.txt URL #19725

Merged
merged 1 commit into from
Dec 28, 2016

Conversation

MichaelHatherly
Copy link
Member

Should fix problems discussed in #18588 (comment). @tkelman is there anything I need to do to have juliacache mirror this, or does that happen automatically?

@tkelman
Copy link
Contributor

tkelman commented Dec 27, 2016

either use deps/tools/jldownload instead of the download function, or prepend juliacache to the url

@tkelman
Copy link
Contributor

tkelman commented Dec 27, 2016

If we're going to cache it here, we should probably change https://github.com/JuliaLang/utf8proc/blob/15e1819cdd326639a49481eb105dee242de99104/data/Makefile#L41 to avoid caching it in utf8proc, otherwise we might get the wrong unicode version cached if the two repos ever don't match.

@tkelman
Copy link
Contributor

tkelman commented Dec 27, 2016

We could also maybe think about adding doc/deps to the travis caching, might save a minute or so of cloning metadata on every build? Though we'd have to invalidate the cache if we ever change the unicode version. Could checksum it perhaps, delete and retry on a checksum mismatch?

edit: on second thought this might leave a mess of every PR that updates metadata causing travis to re-upload a cache for the PR that differs from master, which we'd have to clear out manually every so often

@kshyatt kshyatt added the docsystem The documentation building system label Dec 27, 2016
@MichaelHatherly
Copy link
Member Author

to avoid caching it in utf8proc, otherwise we might get the wrong unicode version cached if the two repos ever don't match.

Would the versions ever not match?

@tkelman
Copy link
Contributor

tkelman commented Dec 27, 2016

Yes, if we make the change in one place then it won't match until we change it in the other. Even if we change it in both places at the exact same time, you'd need to do so on every branch, and never re-run a commit from before doing that.

@MichaelHatherly
Copy link
Member Author

Ok, that makes sense, thanks. So we just need to not cache this file in utf8proc by removing the prefixed URLCACHE on that line, should that be done prior to merging this PR?

@tkelman
Copy link
Contributor

tkelman commented Dec 27, 2016

Could be done after. But we should probably checksum the file here with jlchecksum to be sure we're getting the expected content

@MichaelHatherly
Copy link
Member Author

(Hopefully I've done that jlchecksum correctly, seems to work alright I think...)

@stevengj
Copy link
Member

stevengj commented Dec 27, 2016

Probably utf8proc should export some API to indicate what Unicode version it supports (JuliaStrings/utf8proc#91)

@tkelman tkelman merged commit 30e2ea9 into JuliaLang:master Dec 28, 2016
@MichaelHatherly MichaelHatherly deleted the mh/unicodedata branch December 28, 2016 08:15
tkelman pushed a commit to JuliaStrings/utf8proc that referenced this pull request Jan 4, 2017
Ref: JuliaLang/julia#19725, UnicodeData.txt is
now being cached in JuliaLang/julia's build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants