-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use versioned UnicodeData.txt URL #19725
Conversation
either use deps/tools/jldownload instead of the download function, or prepend juliacache to the url |
96010bf
to
ef10877
Compare
If we're going to cache it here, we should probably change https://github.com/JuliaLang/utf8proc/blob/15e1819cdd326639a49481eb105dee242de99104/data/Makefile#L41 to avoid caching it in utf8proc, otherwise we might get the wrong unicode version cached if the two repos ever don't match. |
We could also maybe think about adding edit: on second thought this might leave a mess of every PR that updates metadata causing travis to re-upload a cache for the PR that differs from master, which we'd have to clear out manually every so often |
Would the versions ever not match? |
Yes, if we make the change in one place then it won't match until we change it in the other. Even if we change it in both places at the exact same time, you'd need to do so on every branch, and never re-run a commit from before doing that. |
Ok, that makes sense, thanks. So we just need to not cache this file in utf8proc by removing the prefixed |
Could be done after. But we should probably checksum the file here with |
ef10877
to
9d52926
Compare
(Hopefully I've done that |
Probably utf8proc should export some API to indicate what Unicode version it supports (JuliaStrings/utf8proc#91) |
Ref: JuliaLang/julia#19725, UnicodeData.txt is now being cached in JuliaLang/julia's build.
Should fix problems discussed in #18588 (comment). @tkelman is there anything I need to do to have juliacache mirror this, or does that happen automatically?