Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Ref in getipaddr and improve type stability #19698

Merged
merged 1 commit into from
Dec 29, 2016

Conversation

stevengj
Copy link
Member

Just a slight improvement I noticed when I was doing something else.

@stevengj
Copy link
Member Author

AppVeyor failure seems to be #16555.

@stevengj
Copy link
Member Author

Merging, since this seems uncontroversial.

@stevengj stevengj merged commit f583495 into JuliaLang:master Dec 29, 2016
@stevengj stevengj deleted the getipaddr branch December 29, 2016 19:42
@tkelman
Copy link
Contributor

tkelman commented Jan 14, 2017

what about this improves type stability?

@yuyichao
Copy link
Contributor

Not reassigning a variable to a different type. This is the known limitation of type inference/codegen that generates inefficient code for type unstable variable even though each use of the variable have a leaftype.

@stevengj
Copy link
Member Author

Yeah, unfortunately it's a quite common pattern to do

function foo(x)
   x = canonicalize(x)
   ...
end

so that x changes type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants