faster inference order #19513
Merged
faster inference order #19513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the idea here is that we want to try to avoid accidentally doing a depth-first scan of the AST but while a breadth-first (dominator) scan is more optimal in terms of avoiding rework, it is also more expensive to compute intead, the idea here is that anytime we hit a goto branch, we instead track whether this is a lower pc waiting for revisit. by preferring lower pc to larger ones, we improve the ability for inference to finish completely inferring all branches of a loop / conditional / try-catch before moving on this depends on the fact that lowering generally keeps these bloks fairly well ordered in the AST. excessive use of `@goto` nodes in the user's code may reduce the effectiveness of this heuristic, but it won't break the algorithm.
vtjnash
added
backport pending 0.5
compiler:inference
vtjnash
force-pushed
the
jn/faster-inference-order
branch
from
c6ea2b4 to
30c9918
Compare
|
for the test case in #15346 with n=1000, this gave me about a 4x speedup on inference time (80s -> 20s), with a corresponding reduction in memory usage as well! |
|
LGTM. |
JeffBezanson
approved these changes
Dec 6, 2016
|
This doesn't cherry-pick cleanly on release-0.5. Please open a PR against tk/backports-0.5.1 if this should be included in 0.5.1. |
|
Yes please let's backport this; Base.Test on Julia v0.5 is still unbearably slow for large testsets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may fix #15346