faster lowercase and uppercase #1884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using uppercase(Uint8,) and lowercase(Uint8,) [ both defined using ccall on string.jl ] it's faster than the pure Julia lower/uppercase(ASCIIString,) implementation.
julia> b=convert(ASCIIString,repeat("abcdef",100000));
julia> for i in 1:5
println("---------------------------------------------------------------------------------------------------------------")
println("previous uppercase:")
@timeit uppercase(b)
println("using uppercase(Uint8,):")
@timeit uppercase2(b)
end
---------------------------------------------------------------------------------------------------------------
previous uppercase:
Mean SD N Min: 2.5549374573619654 0.07316954602845514 141 2.532958984375
using uppercase(Uint8,):
Mean SD N Min: 2.0886501135853672 0.06681727602045176 173 2.043008804321289
---------------------------------------------------------------------------------------------------------------
previous uppercase:
Mean SD N Min: 2.560585103136428 0.07868263538822672 141 2.5289058685302734
using uppercase(Uint8,):
Mean SD N Min: 2.083949270965047 0.060214738113332104 173 2.039194107055664
---------------------------------------------------------------------------------------------------------------
previous uppercase:
Mean SD N Min: 2.5698648276903953 0.08722755484490761 141 2.5289058685302734
using uppercase(Uint8,):
Mean SD N Min: 2.0806378331677666 0.05486057951368713 174 2.03704833984375
---------------------------------------------------------------------------------------------------------------
previous uppercase:
Mean SD N Min: 2.563787690291168 0.07733692736721635 141 2.529144287109375
using uppercase(Uint8,):
Mean SD N Min: 2.083691558396885 0.05892405530791618 173 2.03704833984375
---------------------------------------------------------------------------------------------------------------
previous uppercase:
Mean SD N Min: 2.5600778295638715 0.08236377961843203 141 2.5289058685302734
using uppercase(Uint8,):
Mean SD N Min: 2.0866049507449818 0.06345176087902686 173 2.0341873168945312
|
I'll add an even faster version. |
fredrikekre
added a commit
that referenced
this pull request
Jun 26, 2020
$ git log --pretty=oneline --abbrev=commit f9a5cc7..531861f 531861f6677f434f6d594212d1085ac5bc309328 Make tree hash computation non-fatal when installing artifacts. (#1885) ce4a41ee7d232b90da925fa9ebe246618de8ada4 Misc fixes (#1884) f80d44345f61d0c1a02650f33322f9a330aa77d1 Disable SIGQUIT test that regularly segfaults on CI. (#1883) 2328d1bcd919bd9fc038af3f1cedf43a22d28e30 telemetry: don't send hash without active project 08fe651707d6deb392950f71c3ea776a2c8337c9 telemetry: use RandomDevice for random values c213096ea6210f66945443658b6548012dff5ec9 Improve Artifacts documentation by adding a Basic Usage section (#1879) d8fde7e85b72c86cdae395a1ea13485c193dc35e fix typo in telemetry notice (#1877) 188893dfdb6608cd5bcab18c6d365843cf1c6056 Merge pull request #1871 from JuliaLang/sk/telemetry ab88ea9c3ea05a70c2e014e6ceb5ce55a7fa9cf7 telemetry notice: reword a bit, factor into function 341dfd0bfafb994bd7c71271d2a458e314f3af4c telemetry: don't send salt hash header ae99ba2ed9d9cd7f9962a2515fd62054eb644097 telemetry notice: only print once per process 636d333a263640650d09b08a568e8e128bf6c00c Add a poor-mans file lock for telemetry file. b24ca68ed000139507d179f49a04df7c7b93d14c telemetry: print legal notice first time talking to each pkg server bd07a8d6439ffbe55f9aaf22ea5e2c451ee480cb telemetry: ~/.julia/servers/telemetry.toml for defaults 70dfbd2c59c4110a6c4775414202b4df840acf21 telemetry: HyperLogLog estimator 3e3f9d7a3baf3a96c860d2b1bc895d5fd2d40d35 README: howto build Julia with git checkout of Pkg (#1864) 100eaa9b0ea0a2b95072c77bdf7060e72479fe13 Fix bug which made `registry up` a no-op instead of updating all user-registries. (#1862)
fredrikekre
added a commit
that referenced
this pull request
Jul 28, 2020
$ git log --pretty=oneline --abbrev=commit f9a5cc7..13456b9 13456b944fd21ec180111c6c29d06b610d47d088 Deprecate the REPL command `] generate` (#1923) 3eee6eb25974c2f320706da1b81ce1f7e1d82165 BinaryPlatforms: Recognize MacOS(:aarch64) (#1916) a8cc6d670ebe55002c5d5efb7fb19315c0c1cd55 Telemetry CI variables: add CI_SERVER, JULIA_PKGEVAL, JULIA_REGISTRYCI_AUTOMERGE, and PKGEVAL (#1906) ae897bc44070f902b5b01da80478ed51c1b518c0 Fix invalidations from loading OrderedCollections (#1897) 69bc387b3932d3d709b656e1ef929c4a2592fcee fix path returned from find_install (#1908) 46c9d430d545ecd70b147942857d775b2834e54b Update environments.md (#1896) 20f9b9e14ab59d81991b5984a2f9eb87d38b6230 Merge pull request #1869 from JuliaLang/teh/inval3 605f48849fa6b3bf29e6785967d4ef2249da9976 - only test on nightly, test without Pkg server as well - CI: build docs on nightly 7e0c911591f5d62acb476f74c59a9cad9c7a1f7d Avoid a strange inference limit when broadcasting f92ee5786468a7d0e836a94b0bb09711faef78da Use `maximum(itr; init=default)` d524d0f7f8cfef8abe429d3b947157eacb84f8ea Avoid calling ==(::Any, ::Nothing) in read_field 2acb2f9ca7f8b908954d6fdde074b65e30b8395f Add more type info 9b5e38e0ee2a0747b5ca7125a3a1f347cbd61708 Improve inference for Platform 0ebffb95d9793689d4c72198ae4804b0745ee16e Pre-allocate `seen` to improve inference in `unique(f, itr)` 160efbea2b56dc8a7a9a5ed8f795fa8995a4f09b Eliminate some boxing cdfc445873fc1d5df8838dd080e125bcce587dc6 docs: delete note about gen-project script (#1887) 531861f6677f434f6d594212d1085ac5bc309328 Make tree hash computation non-fatal when installing artifacts. (#1885) ce4a41ee7d232b90da925fa9ebe246618de8ada4 Misc fixes (#1884) f80d44345f61d0c1a02650f33322f9a330aa77d1 Disable SIGQUIT test that regularly segfaults on CI. (#1883) 2328d1bcd919bd9fc038af3f1cedf43a22d28e30 telemetry: don't send hash without active project 08fe651707d6deb392950f71c3ea776a2c8337c9 telemetry: use RandomDevice for random values c213096ea6210f66945443658b6548012dff5ec9 Improve Artifacts documentation by adding a Basic Usage section (#1879) d8fde7e85b72c86cdae395a1ea13485c193dc35e fix typo in telemetry notice (#1877) 188893dfdb6608cd5bcab18c6d365843cf1c6056 Merge pull request #1871 from JuliaLang/sk/telemetry ab88ea9c3ea05a70c2e014e6ceb5ce55a7fa9cf7 telemetry notice: reword a bit, factor into function 341dfd0bfafb994bd7c71271d2a458e314f3af4c telemetry: don't send salt hash header ae99ba2ed9d9cd7f9962a2515fd62054eb644097 telemetry notice: only print once per process 636d333a263640650d09b08a568e8e128bf6c00c Add a poor-mans file lock for telemetry file. b24ca68ed000139507d179f49a04df7c7b93d14c telemetry: print legal notice first time talking to each pkg server bd07a8d6439ffbe55f9aaf22ea5e2c451ee480cb telemetry: ~/.julia/servers/telemetry.toml for defaults 70dfbd2c59c4110a6c4775414202b4df840acf21 telemetry: HyperLogLog estimator 3e3f9d7a3baf3a96c860d2b1bc895d5fd2d40d35 README: howto build Julia with git checkout of Pkg (#1864) 100eaa9b0ea0a2b95072c77bdf7060e72479fe13 Fix bug which made `registry up` a no-op instead of updating all user-registries. (#1862)
fredrikekre
added a commit
that referenced
this pull request
Jul 29, 2020
$ git log --pretty=oneline --abbrev=commit f9a5cc7..13456b9 13456b944fd21ec180111c6c29d06b610d47d088 Deprecate the REPL command `] generate` (#1923) 3eee6eb25974c2f320706da1b81ce1f7e1d82165 BinaryPlatforms: Recognize MacOS(:aarch64) (#1916) a8cc6d670ebe55002c5d5efb7fb19315c0c1cd55 Telemetry CI variables: add CI_SERVER, JULIA_PKGEVAL, JULIA_REGISTRYCI_AUTOMERGE, and PKGEVAL (#1906) ae897bc44070f902b5b01da80478ed51c1b518c0 Fix invalidations from loading OrderedCollections (#1897) 69bc387b3932d3d709b656e1ef929c4a2592fcee fix path returned from find_install (#1908) 46c9d430d545ecd70b147942857d775b2834e54b Update environments.md (#1896) 20f9b9e14ab59d81991b5984a2f9eb87d38b6230 Merge pull request #1869 from JuliaLang/teh/inval3 605f48849fa6b3bf29e6785967d4ef2249da9976 - only test on nightly, test without Pkg server as well - CI: build docs on nightly 7e0c911591f5d62acb476f74c59a9cad9c7a1f7d Avoid a strange inference limit when broadcasting f92ee5786468a7d0e836a94b0bb09711faef78da Use `maximum(itr; init=default)` d524d0f7f8cfef8abe429d3b947157eacb84f8ea Avoid calling ==(::Any, ::Nothing) in read_field 2acb2f9ca7f8b908954d6fdde074b65e30b8395f Add more type info 9b5e38e0ee2a0747b5ca7125a3a1f347cbd61708 Improve inference for Platform 0ebffb95d9793689d4c72198ae4804b0745ee16e Pre-allocate `seen` to improve inference in `unique(f, itr)` 160efbea2b56dc8a7a9a5ed8f795fa8995a4f09b Eliminate some boxing cdfc445873fc1d5df8838dd080e125bcce587dc6 docs: delete note about gen-project script (#1887) 531861f6677f434f6d594212d1085ac5bc309328 Make tree hash computation non-fatal when installing artifacts. (#1885) ce4a41ee7d232b90da925fa9ebe246618de8ada4 Misc fixes (#1884) f80d44345f61d0c1a02650f33322f9a330aa77d1 Disable SIGQUIT test that regularly segfaults on CI. (#1883) 2328d1bcd919bd9fc038af3f1cedf43a22d28e30 telemetry: don't send hash without active project 08fe651707d6deb392950f71c3ea776a2c8337c9 telemetry: use RandomDevice for random values c213096ea6210f66945443658b6548012dff5ec9 Improve Artifacts documentation by adding a Basic Usage section (#1879) d8fde7e85b72c86cdae395a1ea13485c193dc35e fix typo in telemetry notice (#1877) 188893dfdb6608cd5bcab18c6d365843cf1c6056 Merge pull request #1871 from JuliaLang/sk/telemetry ab88ea9c3ea05a70c2e014e6ceb5ce55a7fa9cf7 telemetry notice: reword a bit, factor into function 341dfd0bfafb994bd7c71271d2a458e314f3af4c telemetry: don't send salt hash header ae99ba2ed9d9cd7f9962a2515fd62054eb644097 telemetry notice: only print once per process 636d333a263640650d09b08a568e8e128bf6c00c Add a poor-mans file lock for telemetry file. b24ca68ed000139507d179f49a04df7c7b93d14c telemetry: print legal notice first time talking to each pkg server bd07a8d6439ffbe55f9aaf22ea5e2c451ee480cb telemetry: ~/.julia/servers/telemetry.toml for defaults 70dfbd2c59c4110a6c4775414202b4df840acf21 telemetry: HyperLogLog estimator 3e3f9d7a3baf3a96c860d2b1bc895d5fd2d40d35 README: howto build Julia with git checkout of Pkg (#1864) 100eaa9b0ea0a2b95072c77bdf7060e72479fe13 Fix bug which made `registry up` a no-op instead of updating all user-registries. (#1862)
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
$ git log --pretty=oneline --abbrev=commit f9a5cc7..13456b9 13456b944fd21ec180111c6c29d06b610d47d088 Deprecate the REPL command `] generate` (JuliaLang#1923) 3eee6eb25974c2f320706da1b81ce1f7e1d82165 BinaryPlatforms: Recognize MacOS(:aarch64) (JuliaLang#1916) a8cc6d670ebe55002c5d5efb7fb19315c0c1cd55 Telemetry CI variables: add CI_SERVER, JULIA_PKGEVAL, JULIA_REGISTRYCI_AUTOMERGE, and PKGEVAL (JuliaLang#1906) ae897bc44070f902b5b01da80478ed51c1b518c0 Fix invalidations from loading OrderedCollections (JuliaLang#1897) 69bc387b3932d3d709b656e1ef929c4a2592fcee fix path returned from find_install (JuliaLang#1908) 46c9d430d545ecd70b147942857d775b2834e54b Update environments.md (JuliaLang#1896) 20f9b9e14ab59d81991b5984a2f9eb87d38b6230 Merge pull request JuliaLang#1869 from JuliaLang/teh/inval3 605f48849fa6b3bf29e6785967d4ef2249da9976 - only test on nightly, test without Pkg server as well - CI: build docs on nightly 7e0c911591f5d62acb476f74c59a9cad9c7a1f7d Avoid a strange inference limit when broadcasting f92ee5786468a7d0e836a94b0bb09711faef78da Use `maximum(itr; init=default)` d524d0f7f8cfef8abe429d3b947157eacb84f8ea Avoid calling ==(::Any, ::Nothing) in read_field 2acb2f9ca7f8b908954d6fdde074b65e30b8395f Add more type info 9b5e38e0ee2a0747b5ca7125a3a1f347cbd61708 Improve inference for Platform 0ebffb95d9793689d4c72198ae4804b0745ee16e Pre-allocate `seen` to improve inference in `unique(f, itr)` 160efbea2b56dc8a7a9a5ed8f795fa8995a4f09b Eliminate some boxing cdfc445873fc1d5df8838dd080e125bcce587dc6 docs: delete note about gen-project script (JuliaLang#1887) 531861f6677f434f6d594212d1085ac5bc309328 Make tree hash computation non-fatal when installing artifacts. (JuliaLang#1885) ce4a41ee7d232b90da925fa9ebe246618de8ada4 Misc fixes (JuliaLang#1884) f80d44345f61d0c1a02650f33322f9a330aa77d1 Disable SIGQUIT test that regularly segfaults on CI. (JuliaLang#1883) 2328d1bcd919bd9fc038af3f1cedf43a22d28e30 telemetry: don't send hash without active project 08fe651707d6deb392950f71c3ea776a2c8337c9 telemetry: use RandomDevice for random values c213096ea6210f66945443658b6548012dff5ec9 Improve Artifacts documentation by adding a Basic Usage section (JuliaLang#1879) d8fde7e85b72c86cdae395a1ea13485c193dc35e fix typo in telemetry notice (JuliaLang#1877) 188893dfdb6608cd5bcab18c6d365843cf1c6056 Merge pull request JuliaLang#1871 from JuliaLang/sk/telemetry ab88ea9c3ea05a70c2e014e6ceb5ce55a7fa9cf7 telemetry notice: reword a bit, factor into function 341dfd0bfafb994bd7c71271d2a458e314f3af4c telemetry: don't send salt hash header ae99ba2ed9d9cd7f9962a2515fd62054eb644097 telemetry notice: only print once per process 636d333a263640650d09b08a568e8e128bf6c00c Add a poor-mans file lock for telemetry file. b24ca68ed000139507d179f49a04df7c7b93d14c telemetry: print legal notice first time talking to each pkg server bd07a8d6439ffbe55f9aaf22ea5e2c451ee480cb telemetry: ~/.julia/servers/telemetry.toml for defaults 70dfbd2c59c4110a6c4775414202b4df840acf21 telemetry: HyperLogLog estimator 3e3f9d7a3baf3a96c860d2b1bc895d5fd2d40d35 README: howto build Julia with git checkout of Pkg (JuliaLang#1864) 100eaa9b0ea0a2b95072c77bdf7060e72479fe13 Fix bug which made `registry up` a no-op instead of updating all user-registries. (JuliaLang#1862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using uppercase(Uint8,) and lowercase(Uint8,) [ both defined using ccall on string.jl ] is faster than the pure Julia lower/uppercase(ASCIIString,) implementation.
Benchmark: